Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating the same name for different values using faker #20913

Merged
merged 1 commit into from Sep 9, 2020
Merged

Avoid creating the same name for different values using faker #20913

merged 1 commit into from Sep 9, 2020

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented Sep 9, 2020 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.7.x
Description? Avoid creating the same name for different values
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? No tests needed (Result will be shown at nightly report)

This change is Reviewable

@boubkerbribri boubkerbribri added the TE Category: Tests label Sep 9, 2020
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Sep 9, 2020
@boubkerbribri boubkerbribri requested a review from a team as a code owner September 9, 2020 08:10
@prestonBot prestonBot added 1.7.7.x Branch Refactoring Type: Refactoring labels Sep 9, 2020
@boubkerbribri boubkerbribri changed the title Avoid creating the same name for different values Avoid creating the same name for different values using faker Sep 9, 2020
@SimonGrn SimonGrn merged commit b6439a4 into PrestaShop:1.7.7.x Sep 9, 2020
@PierreRambaud PierreRambaud deleted the fix-faker-attribute-value branch September 9, 2020 08:31
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.7.3 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@SimonGrn SimonGrn SimonGrn approved these changes

Assignees
No one assigned
Labels
1.7.7.x Branch Refactoring Type: Refactoring TE Category: Tests
Projects
No open projects
PrestaShop 1.7.7.3
  
Done
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boubkerbribri @PierreRambaud @SimonGrn @prestonBot