Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix left sidebar while onboarding is on #21250

Merged
merged 1 commit into from Oct 2, 2020
Merged

Fix left sidebar while onboarding is on #21250

merged 1 commit into from Oct 2, 2020

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Oct 1, 2020 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Onboarding was hiding last menu items on the lef navbar in the BO
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #21095.
How to test? Go on a prestashop shop with the onboarding plugin on, you should be able to scroll and see every items in the navbar on legacy and migrated layout (dashboard page and order for example), see the issue for more infos!

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from a team as a code owner October 1, 2020 14:54
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Oct 1, 2020
@NeOMakinG NeOMakinG added the Hacktoberfest Identify Hacktoberfest contributions label Oct 1, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Oct 1, 2020
@SimonGrn SimonGrn added the Waiting for QA Status: action required, waiting for test feedback label Oct 2, 2020
@SimonGrn
Copy link
Contributor

SimonGrn commented Oct 2, 2020

On a small screen I'm able to scroll down to the last item of "Advanced Parameters", in a non-migrated page (Dashboard) :
image
And on a migrated page (Orders):
image

There is a bigger space between the last element and the onboarding block in the migrated page, tho (see pictures).

This is ✔️ .

@SimonGrn SimonGrn added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 2, 2020
@Progi1984 Progi1984 merged commit 52bfa6d into PrestaShop:develop Oct 2, 2020
@Progi1984
Copy link
Contributor

Thanks @NeOMakinG & @SimonGrn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch Hacktoberfest Identify Hacktoberfest contributions QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Left admin panel isn't scroll able - on first tier of menu.
5 participants
@NeOMakinG @SimonGrn @Progi1984 @atomiix @prestonBot