Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build core assets #21507

Merged
merged 1 commit into from Oct 19, 2020
Merged

Build core assets #21507

merged 1 commit into from Oct 19, 2020

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Oct 19, 2020 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.7.x
Description? Build assets
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? ~

This change is Reviewable

@jolelievre jolelievre requested a review from a team as a code owner October 19, 2020 13:35
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added 1.7.7.x Branch Improvement Type: Improvement labels Oct 19, 2020
@jolelievre jolelievre changed the title Build cor assets Build core assets Oct 19, 2020
@jolelievre jolelievre added this to the 1.7.7.0 milestone Oct 19, 2020
NeOMakinG
NeOMakinG approved these changes Oct 19, 2020
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@matks
Copy link
Contributor

matks commented Oct 19, 2020

🥳

🤔 ?

@NeOMakinG
Copy link

🥳

🤔 ?

Jo said that it would be the last asset building, this is an happy time

@jolelievre jolelievre merged commit ae70ab8 into PrestaShop:1.7.7.x Oct 19, 2020
@jolelievre jolelievre deleted the build-assets branch October 19, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
1.7.7.x Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jolelievre @prestonBot @matks @NeOMakinG @PierreRambaud @Progi1984 @matthieu-rolland