Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly 1.7.7.x - 05/01/2021 #22678

Merged
merged 2 commits into from Jan 12, 2021
Merged

Fix nightly 1.7.7.x - 05/01/2021 #22678

merged 2 commits into from Jan 12, 2021

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Jan 5, 2021 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.7.x
Description? Fix enable/disable merchandise return test
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? no
Possible impacts? TEST_PATH="functional/BO/05_customerService/03_merchandiseReturns/01_activateMerchandiseReturn.js" URL_FO=yourShopURL npm run specific-test

This change is Reviewable

@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner January 5, 2021 14:46
@prestonBot prestonBot added 1.7.7.x Branch Refactoring Type: Refactoring labels Jan 5, 2021
@nesrineabdmouleh nesrineabdmouleh added the TE Category: Tests label Jan 5, 2021
@nesrineabdmouleh nesrineabdmouleh added this to the 1.7.7.2 milestone Jan 5, 2021
@Progi1984 Progi1984 added the QA ✔️ Status: check done, code approved label Jan 5, 2021
Progi1984
Progi1984 previously requested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAITING FOR 1771 RELEASE

@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Jan 5, 2021
@PierreRambaud PierreRambaud dismissed Progi1984’s stale review January 12, 2021 14:25

1.7.7.1 has been released

@PierreRambaud PierreRambaud removed the Waiting for author Status: action required, waiting for author feedback label Jan 12, 2021
@PierreRambaud PierreRambaud merged commit d304878 into PrestaShop:1.7.7.x Jan 12, 2021
@PierreRambaud
Copy link
Contributor

Thank you @nesrineabdmouleh

@nesrineabdmouleh nesrineabdmouleh deleted the fixNightly05/01 branch April 6, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

@SimonGrn SimonGrn SimonGrn approved these changes

@Progi1984 Progi1984 Progi1984 left review comments

Assignees
No one assigned
Labels
1.7.7.x Branch QA ✔️ Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.7.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nesrineabdmouleh @PierreRambaud @Progi1984 @boubkerbribri @SimonGrn @prestonBot