Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JS Routing file #23781

Merged
merged 1 commit into from Mar 26, 2021
Merged

Updated JS Routing file #23781

merged 1 commit into from Mar 26, 2021

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Mar 25, 2021

Questions Answers
Branch? develop
Description? Updated JS Routing file
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A
Possible impacts? N/A

This change is Reviewable

@github-actions github-actions bot requested a review from a team as a code owner March 25, 2021 23:09
@prestonBot
Copy link
Collaborator

Hello @github-actions[bot]!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Mar 25, 2021
@matthieu-rolland matthieu-rolland merged commit 317119b into develop Mar 26, 2021
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@eternoendless eternoendless deleted the create-pull-request/patch branch March 26, 2021 13:43
@atomiix atomiix added this to the 1.7.8.0 milestone Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants