Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use object mapping in multistore-header js #24009

Merged
merged 1 commit into from Apr 15, 2021
Merged

Use object mapping in multistore-header js #24009

merged 1 commit into from Apr 15, 2021

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Apr 12, 2021 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? This is a minor refactor in multistore header's javascript: use new js components's map object in multistore-header.js
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #24008
How to test? This is a pure frontend PR, so you can just check that the multistore header and multistore dropdown are still displayed correctly, and are not broken. You don't need to deep test it (all things related to context, whether the elements should be displayed or not, etc... are not impacted by this PR, is frontend only)
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from a team as a code owner April 12, 2021 12:53
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Apr 12, 2021
@Progi1984 Progi1984 changed the title use object mapping in multistore-header js Use object mapping in multistore-header js Apr 12, 2021
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Apr 12, 2021
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Apr 12, 2021
@sarahdib sarahdib self-assigned this Apr 15, 2021
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 15, 2021
@PierreRambaud PierreRambaud merged commit 0cb5516 into PrestaShop:develop Apr 15, 2021
@PierreRambaud
Copy link
Contributor

Thank you @matthieu-rolland & @sarahdib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees

@sarahdib sarahdib

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Use a map object in multistore header javascript
6 participants
@matthieu-rolland @PierreRambaud @Progi1984 @NeOMakinG @sarahdib @prestonBot