Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed check on array in template Smarty #24610

Merged
merged 1 commit into from May 25, 2021
Merged

Fixed check on array in template Smarty #24610

merged 1 commit into from May 25, 2021

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented May 21, 2021 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.8.x
Description? Fixed check on array in template Smarty for PHP 7.4
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #24574
How to test? Cf. #24574

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner May 21, 2021 13:18
@prestonBot prestonBot added 1.7.8.x Branch Bug fix Type: Bug fix labels May 21, 2021
@Progi1984 Progi1984 linked an issue May 21, 2021 that may be closed by this pull request
FO - An exception is displayed in the category page when creating new category - PHP7.4 #24574
Closed
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone May 21, 2021
@atomiix atomiix added the Waiting for QA Status: action required, waiting for test feedback label May 24, 2021
@khouloudbelguith khouloudbelguith self-assigned this May 25, 2021
@khouloudbelguith
Copy link
Contributor

Hi @Progi1984,

It is ok ✔️
I checked PHP7.4 and PHP7.2
https://drive.google.com/file/d/1aFn9L3Z2ek_fxYVPOXu36YFu27N1PpPN/view?usp=sharing

Thank you!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 25, 2021
@PululuK PululuK merged commit c2461be into PrestaShop:1.7.8.x May 25, 2021
@PululuK
Copy link
Member

PululuK commented May 25, 2021

Thanks @Progi1984 @khouloudbelguith

@PululuK PululuK mentioned this pull request May 25, 2021
Closed
@Progi1984 Progi1984 deleted the issue24574 branch May 25, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@atomiix atomiix atomiix approved these changes

Assignees

@khouloudbelguith khouloudbelguith

Labels
1.7.8.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

FO - An exception is displayed in the category page when creating new category - PHP7.4
6 participants
@Progi1984 @khouloudbelguith @PululuK @PierreRambaud @atomiix @prestonBot