Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create-test-db #24736

Merged
merged 1 commit into from Jun 2, 2021
Merged

Fix create-test-db #24736

merged 1 commit into from Jun 2, 2021
+2 −9

Conversation

zuk3975
Copy link
Contributor

@zuk3975 zuk3975 commented Jun 2, 2021 •
edited

Questions Answers
Branch? 1.7.8.x
Description? Some database tables were missing, because doctrine schema wasn't loaded.
Type? bug fix
Category? BO
BC breaks? yes - rename method src/PrestaShopBundle/Install/Install.php::generateSf2ProductionEnv() -> updateSchema().
Deprecations? no
Fixed ticket? #24547
How to test? run composer create-test-db and no errors + test_{your_prestashop_db_name} database created locally.
Possible impacts? Need to double check if all prestashop installation methods are still working (install through web /install-dev and console command (/install-dev/index_cli)

This change is Reviewable

@zuk3975 zuk3975 requested a review from a team as a code owner June 2, 2021 06:49
@prestonBot prestonBot added 1.7.8.x Branch Bug fix Type: Bug fix labels Jun 2, 2021
@zuk3975 zuk3975 mentioned this pull request Jun 2, 2021
Closed
@zuk3975
Copy link
Contributor Author

zuk3975 commented Jun 2, 2021

@Robin-Fischer-PS:
Hi there,
QA will pass some tests, but if the dev can test the more technical part (CLI install) it would be nice :)

I've checked the cli & web installation, it works as expected

@Robin-Fischer-PS
Copy link
Contributor

Thanks @zuk3975 ! As seen with @PierreRambaud , he tested it, so it's QA ✔️ !

@Robin-Fischer-PS Robin-Fischer-PS added the QA ✔️ Status: check done, code approved label Jun 2, 2021
@PierreRambaud PierreRambaud merged commit b948794 into PrestaShop:1.7.8.x Jun 2, 2021
@PierreRambaud
Copy link
Contributor

Thank you @zuk3975 and @Robin-Fischer-PS

@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@matks matks added this to the 1.7.8.0 milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
1.7.8.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zuk3975 @Robin-Fischer-PS @PierreRambaud @prestonBot @matthieu-rolland @matks