Add shop details support to classic

[Hlavtox]

Questions	Answers
Branch?	develop
Description?	Legal information is not displayed on contact page, while there is a field for that in Prestashop settings.
Type?	improvement
Category?	FO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #26809
How to test?	Fill the legal info in BO, apply PrestaShop/ps_contactinfo#43 and go to contact page.
Possible impacts?	None.

---

This change is 

[prestonBot]

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

• Admin.Shopparameters.Feature
  • Company details
• Admin.Shopparameters.Help
  • Company's registration details (e.g. DNI, VAT, SIRET, RCS, etc.).
• Shop.Theme.Global
  • Company details:

(Note: this is an automated message, but answering it will reach a real human)

[Julievrz]

Hi @Hlavtox

I've tried to test the PR to better understand the context of the wording. But the registration number doesn't appear on the front office with your PR. Is it just me?

[Hlavtox]

@Julievrz Hi, you must also apply PR from PrestaShop/ps_contactinfo#43.

[Julievrz]

Thanks!
So instead of having "Details:" what about having "Registration number:" like in the back office?

[Hlavtox]

@Julievrz It can't be called "Registration number". For example, in Czech republic, you are required by the law to specify a lot more information, and Contact page is the best way to do it. We should also make line breaks working in this input, or just make it a free HTML.

On top of company name, address, phone, email also:

• Registration number: 12345678
• Registration information: The company is registered in the Commercial Register kept at the Regional Court in Prague in section C, insert 32726.
• VAT number: CZ12345678

[Julievrz]

@Julievrz It can't be called "Registration number". For example, in Czech republic, you are required by the law to specify a lot more information, and Contact page is the best way to do it. We should also make line breaks working in this input, or just make it a free HTML.

On top of company name, address, phone, email also:

• Registration number: 12345678
• Registration information: The company is registered in the Commercial Register kept at the Regional Court in Prague in section C, insert 32726.
• VAT number: CZ12345678

Ok, I understand your point. However, when checking PrestaShop websites, it seems that merchants tend to use the "Legal notice" page to display these details.

https://www.lechocolatdesfrancais.fr/en/

https://www.poupadou.com/en/content/legal-notice-2

https://www.pylones.com/en/content/5-legal-notices

Anyway, I'm not against keeping "Details:". It's quite generic wording and merchants will still be able to modify it according to their needs. I'm just not sure to understand the difference between this and the legal notice. :-)

[Hlavtox]

@Julievrz That field was definitely meant to contain more info. It's multiline. It's even written in the helpbox ("Registration information (company ID, VAT number)".

I think that line break support or ability to enter HTML should be provided in a separate PR.

---

Also, I randomly checked 4 stores I know from memory, where I buy stuff on regular basis. One of the best stores in their field. All have VAT number and registration info on their contact page. 👍

• https://www.ventilatory.cz/kontakt
• https://www.ahifi.cz/adresa-oteviraci-doba-a-kontakty/
• https://www.mall.cz/kontakt
• https://www.notino.cz/kontakt/

[Julievrz]

@Julievrz That field was definitely meant to contain more info. It's multiline. It's even written in the helpbox ("Registration information (company ID, VAT number)".

I think that line break support or ability to enter HTML should be provided in a separate PR.

Also, I randomly checked 4 stores I know from memory, where I buy stuff on regular basis. One of the best stores in their field. All have VAT number and registration info on their contact page. 👍

• https://www.ventilatory.cz/kontakt
• https://www.ahifi.cz/adresa-oteviraci-doba-a-kontakty/
• https://www.mall.cz/kontakt
• https://www.notino.cz/kontakt/

Yes, I totally understand! I think the label in the BO is quite confusing though. We can go for "Company details:" if it suits you. ☺️

[Hlavtox]

@Julievrz Wording applied, I also changed it in BO, can you check? :-)

[Hlavtox]

Also, added support for line breaks.

[khouloudbelguith]

Hi @Hlavtox,

I tested this PR using this PR.
The wording is ok in the BO

In the FO > in the footer => is not displayed

Thanks!

[Hlavtox]

@khouloudbelguith I didn't implement it, I don't think it's needed there...

[khouloudbelguith]

Hi @Hlavtox,

In fact, as you can see in this comment
The registration number should be displayed in the contact page but also in the footer, under the email.
This behavior is validated by the product team.

Thank you!

[Progi1984]

Hi @Hlavtox,
Since we had no news from you for more than 30 days, I'll close this pull request. Feel free to reopen or open another one if you think it's still relevant.
Thanks!

[fabiocranchi]

Solution:

Edit the file /modules/ps_contactinfo/ps_contactinfo.php
In array $contact_infos, add this line: 'regNumber' => Configuration::get('PS_SHOP_DETAILS'),
In the file just below the line 'company' => Configuration::get('PS_SHOP_NAME'),
Add: 'regNumber' => Configuration::get('PS_SHOP_DETAILS'),

Then, inside the theme, search for ps_contactinfo.tpl and add "
{$contact_infos.regNumber}" without quotes just below "{$contact_infos.address.formatted nofilter}"

tpl file location in classic theme:
themes/classic/modules/ps_contactinfo

Hope it helped =)

[fabiocranchi]

Hi @Hlavtox,

I tested this PR using this PR. The wording is ok in the BO In the FO > in the footer => is not displayed

Thanks!

Solution:

Edit the file /modules/ps_contactinfo/ps_contactinfo.php
In array $contact_infos, add this line: 'regNumber' => Configuration::get('PS_SHOP_DETAILS'),
In the file just below the line 'company' => Configuration::get('PS_SHOP_NAME'),
Add: 'regNumber' => Configuration::get('PS_SHOP_DETAILS'),

Then, inside the theme, search for ps_contactinfo.tpl and add "
{$contact_infos.regNumber}" without quotes just below "{$contact_infos.address.formatted nofilter}"

tpl file location in classic theme:
themes/classic/modules/ps_contactinfo

Hope it helped =)