Allow overriding _PS_DISPLAY_COMPATIBILITY_WARNING_ in defines_custom.inc.php

[PrestaEdit]

Questions	Answers
Branch?	develop
Description?	With the usage of defines_custom.inc.php file, we can define some consts but not the _PS_DISPLAY_COMPATIBILITY_WARNING_ one.
Type?	improvement
Category?	CO
BC breaks?	no
Deprecations?	no
How to test?	n/d.
Possible impacts?	n/d.

---

This change is 

[prestonBot]

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

• Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

• If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
• It can help trigger a discussion about the best implementation path before a single line of code is written.
• It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

[matthieu-rolland]

hello, did you have a peculiar use case where this was necessary ?

Anyway it looks good to me, I don't see any drawback, let's see what other devs thing about this 🤔

[PrestaEdit]

Hi @matthieu-rolland ,

No really use case, just a "best" practice. I'm surely the only one to say that we need to enable the debug mode into this file and not editing the main file, but, yeah, is that :D

As likely every others defines could be set before this file, it could be usefull to have it on the same files as others ;-)

[matthieu-rolland]

I see, I still approve your PR, let's see what other reviewers think about this ;)

[sowbiba]

seems harmless

[Robin-Fischer-PS]

Hi,

No issue linked, no how to test... This must be tested by a dev ;)

Thanks.

[atomiix]

Thanks @PrestaEdit