Support disabling DEV_MODE on Docker #27138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boubkerbribri
changed the title
PierreRambaud
approved these changes
Dec 29, 2021
Progi1984
approved these changes
Dec 29, 2021
|
Thank you @boubkerbribri |
SharakPL
reviewed
Jan 25, 2023
| @@ -30,6 +30,11 @@ fi | |||
| # From now, stop at error | |||
| set -e | |||
|
|
|||
| if [ $PS_DEV_MODE -ne 1 ]; then | |||
| echo "\n* Disabling DEV mode ..."; | |||
| sed -ie "s/define('_PS_MODE_DEV_', true);/define('_PS_MODE_DEV_',\ false);/g" /var/www/html/config/defines.inc.php | |||
There was a problem hiding this comment.
@boubkerbribri just wondering, why did you use -ie flag which generates defines.inc.phpe file? Is this supposed to be a backup? What's the point of that?
There was a problem hiding this comment.
I think it's an error that slipped away here
There was a problem hiding this comment.
I'm making a PR for the config so I'll fix that too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-compose uo --buildThis change is