Allow clearing modules cache for all shops #28445

sowbiba · 2022-05-09T11:27:13Z

Questions	Answers
Branch?	develop
Description?	Add parameter to allow clearing the modules list cache for all shops, in a multishop context
Type?	bug fix
Category?	CO
BC breaks?	yes
Deprecations?	no
Fixed ticket?	Fixes #28446
How to test?	Please use prestashopexamplemodule.zip which implements "enable/disable all shops at once"

BC Breaks

ModuleRepository::clearCache now have a second optional parameter $allShop, boolean type, default to false, to allow clearing the cache for all the shops of the BO

src/Core/Module/ModuleRepository.php

Progi1984

A small feedback

Progi1984 · 2022-05-09T16:13:40Z

A small feedback

Progi1984

A small comment

src/Core/Module/ModuleRepository.php

Progi1984

@sowbiba If you have time for adding PHPDoc, it will be better

jolelievre

Thanks @sowbiba

src/Core/Module/ModuleRepository.php

Progi1984

A last feedback for inheritance

Co-authored-by: Progi1984 <progi1984@gmail.com>

marwachelly · 2022-05-18T09:37:48Z

Hello @sowbiba,

The issue is a regression 1.7.8.0 so I think it should be fixed on 1.7.8.x branch.
Also I noticed without the PR that the problem is not present on the branch develop following the scenario :

Enable multistore
Create a new shop
All shop is selected

on develop :

When All shop is selected (we have only the options unistall and reset)

When a specific shop is selected(we have the options : Disable Mobile/Disable/reset and Uninstall)

on 1.7.8.x :

When All shop is selected(we have the options : Disable Mobile/Disable/reset and Uninstall)

When a specific shop is selected(we have the options : Disable Mobile/Disable/reset and Uninstall)

Ping @PrestaShop/product-team Is it a wanted behavior?

Thanks,

sowbiba · 2022-05-26T18:57:52Z

I'm sorry @marwachelly but you are looking the wrong direction
The actions available are not the subject. Maybe there is an issue, I don't know

Here it's about the consistency of the module status for every shop (single shop context)

In my example from the issue, the module is supposed to be disabled in the 2 shops but it's displayed as active in Shop1 and inactive for Shop2. If you remove the cache, the statuses are correct

marwachelly

I'm sorry @marwachelly but you are looking the wrong direction The actions available are not the subject. Maybe there is an issue, I don't know

Here it's about the consistency of the module status for every shop (single shop context)

In my example from the issue, the module is supposed to be disabled in the 2 shops but it's displayed as active in Shop1 and inactive for Shop2. If you remove the cache, the statuses are correct

Hello @sowbiba,

Setting the module active / inactive in the develop branch in all shop context is not posssible. (When All shop is selected (we have only the options unistall and reset) So the bug is not reproducible on the branch develop.

Untitled_.May.30.2022.2_52.PM.mp4

The bug is reproducible also with PS 1.7.8.x and incognito browsing:

Untitled_.May.30.2022.3_33.PM.mp4

The bug is reproducible with PS1.7.7.8:

Untitled_.May.30.2022.3_41.PM.mp4

@PrestaShop/product-team Could you please check my comment above?

Thanks,

sowbiba · 2022-05-30T14:30:26Z

Hello @marwachelly
Select Shop 1, activate the module
Select Shop 2, see that the module is still disabled

marwachelly · 2022-05-30T14:49:15Z

Hello @marwachelly Select Shop 1, activate the module Select Shop 2, see that the module is still disabled

Did you mean that?

Untitled_.May.30.2022.3_45.PM.mp4

But I think this is the expected behavior. The shop1 shouldn't have an influence on shop2. Isn't it?

even with incognito browsing on develop and without PR i didn't manage to reproduce the issue

Untitled_.May.30.2022.4_09.PM.mp4

Did I miss something?

Thanks,

sowbiba · 2022-05-30T15:28:02Z

exactly you got it !!

It's the expected behaviour because the module is coded like that
In a module you can have your own logic about what to do when enabling/disabling the module in a multishop context

For my module given in the example, the status is consistant between all the shops : disabling in one shop will make it disabled for the whole Backoffice. But I can't do this because of the cache which is not cleared after the actions

marwachelly

Hello @sowbiba ,

PR is tested and the issue is fixed.

Untitled_.Jun.1.2022.4_36.PM.mp4

I detected an exception relaed to the module. As discussed in slack, the exception is not blocking the PR (just it is related to the module).

So PR is QA ✔️

Many thanks,

sowbiba · 2022-06-01T16:09:39Z

Thank you all ❤️

sowbiba requested a review from a team as a code owner May 9, 2022 11:27

prestonBot added develop Branch Bug fix Type: Bug fix BC break Type: Introduces a backwards-incompatible break labels May 9, 2022

sowbiba force-pushed the clear-module-cache-all-shops branch from d43b557 to da3d940 Compare May 9, 2022 11:39

Progi1984 reviewed May 9, 2022

View reviewed changes

src/Core/Module/ModuleRepository.php Outdated Show resolved Hide resolved

Progi1984 reviewed May 9, 2022

View reviewed changes

sowbiba force-pushed the clear-module-cache-all-shops branch from 5a655bf to d26b527 Compare May 9, 2022 12:22

sowbiba requested a review from Progi1984 May 9, 2022 19:45

Progi1984 reviewed May 10, 2022

View reviewed changes

src/Core/Module/ModuleRepository.php Outdated Show resolved Hide resolved

sowbiba requested a review from Progi1984 May 10, 2022 08:40

Progi1984 previously approved these changes May 11, 2022

View reviewed changes

Allow clearing modules cache for all shops

4a34c76

sowbiba dismissed Progi1984’s stale review via 4a34c76 May 11, 2022 09:41

sowbiba force-pushed the clear-module-cache-all-shops branch from 9bb1215 to 4a34c76 Compare May 11, 2022 09:41

Add php doc for the modified methods

ed00ab4

sowbiba requested a review from Progi1984 May 11, 2022 09:45

jolelievre previously approved these changes May 11, 2022

View reviewed changes

Progi1984 added this to the 8.0.0 milestone May 12, 2022

Progi1984 reviewed May 13, 2022

View reviewed changes

src/Core/Module/ModuleRepository.php Outdated Show resolved Hide resolved

Progi1984 reviewed May 13, 2022

View reviewed changes

sowbiba dismissed jolelievre’s stale review via ad66e44 May 16, 2022 09:37

Update src/Core/Module/ModuleRepository.php

ad66e44

Co-authored-by: Progi1984 <progi1984@gmail.com>

sowbiba requested review from Progi1984, matks and jolelievre May 16, 2022 11:48

Progi1984 approved these changes May 17, 2022

View reviewed changes

matks approved these changes May 17, 2022

View reviewed changes

matks added the Needs documentation Needs an update of the developer documentation label May 17, 2022

matks added the Waiting for QA Status: action required, waiting for test feedback label May 17, 2022

marwachelly self-assigned this May 17, 2022

marwachelly added Waiting for author Status: action required, waiting for author feedback Waiting for PM Status: action required, waiting for product feedback and removed Waiting for QA Status: action required, waiting for test feedback labels May 18, 2022

sowbiba added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels May 27, 2022

marwachelly reviewed May 30, 2022

View reviewed changes

marwachelly added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels May 30, 2022

sowbiba added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels May 30, 2022

marwachelly approved these changes Jun 1, 2022

View reviewed changes

marwachelly added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback Waiting for PM Status: action required, waiting for product feedback labels Jun 1, 2022

sowbiba merged commit edcf2ff into PrestaShop:develop Jun 1, 2022

sowbiba deleted the clear-module-cache-all-shops branch June 1, 2022 16:09

kpodemski added Documentation ✔️ Developer documentation is up-to-date and removed Needs documentation Needs an update of the developer documentation labels Aug 4, 2022

kpodemski mentioned this pull request Aug 4, 2022

Documentation for BC Breaks and changes in 8.0 PrestaShop/docs#1427

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow clearing modules cache for all shops #28445

Allow clearing modules cache for all shops #28445

sowbiba commented May 9, 2022 •

edited

Progi1984 left a comment

Progi1984 commented May 9, 2022

Progi1984 left a comment

Progi1984 left a comment

jolelievre left a comment

Progi1984 left a comment

marwachelly commented May 18, 2022

sowbiba commented May 26, 2022 •

edited

marwachelly left a comment •

edited

sowbiba commented May 30, 2022

marwachelly commented May 30, 2022 •

edited

sowbiba commented May 30, 2022 •

edited

marwachelly left a comment •

edited

sowbiba commented Jun 1, 2022

Navigation Menu

Allow clearing modules cache for all shops #28445

Allow clearing modules cache for all shops #28445

Conversation

sowbiba commented May 9, 2022 • edited

BC Breaks

Progi1984 left a comment

Choose a reason for hiding this comment

Progi1984 commented May 9, 2022

Progi1984 left a comment

Choose a reason for hiding this comment

Progi1984 left a comment

Choose a reason for hiding this comment

jolelievre left a comment

Choose a reason for hiding this comment

Progi1984 left a comment

Choose a reason for hiding this comment

marwachelly commented May 18, 2022

sowbiba commented May 26, 2022 • edited

marwachelly left a comment • edited

Choose a reason for hiding this comment

sowbiba commented May 30, 2022

marwachelly commented May 30, 2022 • edited

sowbiba commented May 30, 2022 • edited

marwachelly left a comment • edited

Choose a reason for hiding this comment

sowbiba commented Jun 1, 2022

sowbiba commented May 9, 2022 •

edited

sowbiba commented May 26, 2022 •

edited

marwachelly left a comment •

edited

marwachelly commented May 30, 2022 •

edited

sowbiba commented May 30, 2022 •

edited

marwachelly left a comment •

edited