Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config vars in GetOrderForViewingHandler #28460

Merged

Conversation

PululuK
Copy link
Member

@PululuK PululuK commented May 11, 2022

Questions Answers
Branch? develop
Description? This change fixes minor code issues I found while working on another bug.
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Related PRs N/A
How to test? Please create an order but do not pay it. Please verify that the "Payment" block displays correctly in the back office "View an order" page
Possible impacts? N/A

@PululuK PululuK requested a review from a team as a code owner May 11, 2022 09:06
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels May 11, 2022
@Progi1984 Progi1984 changed the title use config vars in GetOrderForViewingHandler Use config vars in GetOrderForViewingHandler May 11, 2022
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the configuration has a better method.

Co-authored-by: Progi1984 <progi1984@gmail.com>
@PululuK PululuK requested a review from Progi1984 May 11, 2022 14:00
@matks matks added the Waiting for QA Status: action required, waiting for test feedback label May 13, 2022
@Progi1984 Progi1984 added this to the 8.0.0 milestone May 16, 2022
@AureRita AureRita self-assigned this May 17, 2022
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PululuK

Thank you for you PR, I run an automated regression test on it, just in case, and I tested with the creation of an order without pay it, you can see that there is no difference :

With the PR
image

Without the PR
image

With all of tests, I can approve the PR

@AureRita AureRita added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 17, 2022
@Progi1984 Progi1984 merged commit 9cd7941 into PrestaShop:develop May 17, 2022
@Progi1984
Copy link
Contributor

Thanks @PululuK & @AureRita

@PululuK PululuK deleted the refacto-GetOrderForViewingHandler branch May 17, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch QA ✔️ Status: check done, code approved Refactoring Type: Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants