New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use config vars in GetOrderForViewingHandler
#28460
Use config vars in GetOrderForViewingHandler
#28460
Conversation
PululuK
commented
May 11, 2022
•
edited by matks
edited by matks
Questions | Answers |
---|---|
Branch? | develop |
Description? | This change fixes minor code issues I found while working on another bug. |
Type? | refacto |
Category? | CO |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | N/A |
Related PRs | N/A |
How to test? | Please create an order but do not pay it. Please verify that the "Payment" block displays correctly in the back office "View an order" page |
Possible impacts? | N/A |
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
GetOrderForViewingHandler
GetOrderForViewingHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the configuration has a better method.
Co-authored-by: Progi1984 <progi1984@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PululuK
Thank you for you PR, I run an automated regression test on it, just in case, and I tested with the creation of an order without pay it, you can see that there is no difference :
With all of tests, I can approve the PR