New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Module installation handle class constants correctly #2877

Merged
merged 3 commits into from May 13, 2015

Conversation

Projects
None yet
4 participants
@tiennou
Contributor

tiennou commented Apr 15, 2015

This is an enhancement to Module::add/removeOverride so it doesn't treat constants as properties, thus preventing an utter failure to rewrite them.

tiennou added some commits Apr 3, 2015

[*] CORE : Handle constants in overrides as constants
This fixes an issue where constants would get duplicated by the property code, which would cause uninstalls of the module to fail with a "duplicate constant" Runtime Error.
@tiennou

This comment has been minimized.

Show comment
Hide comment
@tiennou

tiennou Apr 15, 2015

Contributor

Note that this mostly enable developers to keep their class constants where they belong without breaking the uninstall process because of "duplicate constant" PHP errors.

Contributor

tiennou commented Apr 15, 2015

Note that this mostly enable developers to keep their class constants where they belong without breaking the uninstall process because of "duplicate constant" PHP errors.

@jnadaud jnadaud removed the pending review label May 13, 2015

jnadaud pushed a commit that referenced this pull request May 13, 2015

Jérôme Nadaud
Merge pull request #2877 from tiennou/module-constants
Make Module installation handle class constants correctly

@jnadaud jnadaud merged commit ae0ef94 into PrestaShop:1.6 May 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jnadaud

This comment has been minimized.

Show comment
Hide comment
@jnadaud

jnadaud May 13, 2015

Contributor

Hi,

Thank you for your contribution, maybe you have not noticed this : http://doc.prestashop.com/display/PS16/How+to+write+a+commit+message

Best regards.

Contributor

jnadaud commented May 13, 2015

Hi,

Thank you for your contribution, maybe you have not noticed this : http://doc.prestashop.com/display/PS16/How+to+write+a+commit+message

Best regards.

@tiennou

This comment has been minimized.

Show comment
Hide comment
@tiennou

tiennou May 13, 2015

Contributor

Heh I actually did 😭. Care to elaborate so I get it right onwards ?

Contributor

tiennou commented May 13, 2015

Heh I actually did 😭. Care to elaborate so I get it right onwards ?

@tiennou tiennou deleted the tiennou:module-constants branch May 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment