Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add employee info on the Payments tab when payment is registered #28820

Merged
merged 3 commits into from Aug 4, 2022
Merged

Add employee info on the Payments tab when payment is registered #28820

merged 3 commits into from Aug 4, 2022

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Jun 22, 2022 •
edited by Hlavtox

Questions Answers
Branch? develop
Description? Add employee info on the Payments tab when payment is registered
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14547
How to test? Cf #14547

Autoupgrade PR - PrestaShop/autoupgrade#595

@Progi1984 Progi1984 requested a review from a team as a code owner June 22, 2022 14:59
@prestonBot prestonBot added develop Branch Feature Type: New Feature labels Jun 22, 2022
@Progi1984 Progi1984 added this to the 8.1.0 milestone Jun 22, 2022
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Jun 22, 2022
ghost
ghost previously approved these changes Jun 23, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget autoupgrade.

@Progi1984
Copy link
Contributor Author

@okom3pom It will be done after the merge ;)

@Julievrz Julievrz added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Jun 23, 2022
@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Jun 23, 2022
@florine2623 florine2623 self-assigned this Jun 29, 2022
florine2623
florine2623 reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

Thanks for the PR

Tested the following :

  • add payments by employee
  • modified name of employee
  • add payments by another employee
  • if no employee, wording is ok
  • tested with different profiles

Works well ✅

Would it be possible to move the Add button to the right so it is aligned with its column ?
Screenshot 2022-06-29 at 11 21 27

Thanks!

@florine2623 florine2623 added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 29, 2022
@Progi1984 Progi1984 dismissed stale reviews from ghost and matthieu-rolland via bcae42e June 29, 2022 12:06
@prestonBot prestonBot added Waiting for wording Status: action required, waiting for wording and removed Wording ✔️ Status: check done, wording approved labels Jun 29, 2022
@Progi1984
Copy link
Contributor Author

@florine2623 Only fixed that.

@matthieu-rolland & @okom3pom Rebased and fixed the small bug for @florine2623.

@Progi1984 Progi1984 added Wording ✔️ Status: check done, wording approved and removed Waiting for author Status: action required, waiting for author feedback Waiting for wording Status: action required, waiting for wording labels Jun 29, 2022
ghost
ghost previously approved these changes Jun 29, 2022
View reviewed changes
@prestonBot prestonBot added Waiting for wording Status: action required, waiting for wording and removed Wording ✔️ Status: check done, wording approved labels Aug 2, 2022
@Progi1984 Progi1984 requested review from a user and matks August 2, 2022 10:11
@ghost ghost added Waiting for QA Status: action required, waiting for test feedback Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Aug 4, 2022
florine2623
florine2623 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

LGTM.
Checked for multiple employees with different Profiles.
Added multiple payments to the orders.

Ran automated tests also ✅

It is QA ✅

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 4, 2022
@matthieu-rolland
Copy link
Contributor

thank you @Progi1984 and @florine2623 !

@matthieu-rolland matthieu-rolland merged commit d1e14ec into PrestaShop:develop Aug 4, 2022
@Progi1984 Progi1984 deleted the issue14547 branch August 4, 2022 13:13
@omar2886
Copy link

omar2886 commented Aug 5, 2022

Finally! this is a very critical thing much needed, don't know why was not implemented long time ago.
Can you please tell me how to do to implement it? is this a manual thing to do overriding the 12 modified files or is there a much better approach in the long term? to avoid problems when upgrading modules or Prestashop itself

@ghost
Copy link

ghost commented Aug 5, 2022

@omar2886 If you do not give more information we can not answer you ( version ... )

@omar2886
Copy link

omar2886 commented Aug 5, 2022

@omar2886 If you do not give more information we can not answer you ( version ... )

Sorry thought it was something generic that does not need much details from each version. In my case is v1.7.6.1

@ghost
Copy link

ghost commented Aug 5, 2022

In a test environment you should be able to modify the files to check if it works. You don't need to add the files from the test directory.

This is manual work, the modification will be effective in version 8.1.0

@Hlavtox
Copy link
Contributor

Hlavtox commented Dec 11, 2022

@PrestaShop/commiters It seems that autougprade PR is missing for this.
@Progi1984 Can you check please?

@BenTen BenTen mentioned this pull request Jul 5, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@florine2623 florine2623 florine2623 approved these changes

@matks matks Awaiting requested review from matks

Assignees

@florine2623 florine2623

Labels
develop Branch Feature Type: New Feature QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

Add employee info on the PaymentPanel when payment is registered
9 participants
@Progi1984 @matthieu-rolland @omar2886 @Hlavtox @matks @florine2623 @prestonBot @MatShir @Julievrz