Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme_dir smarty global var in front contoller #30383

Merged
merged 1 commit into from Nov 29, 2022

Conversation

hendaghanmi
Copy link
Contributor

@hendaghanmi hendaghanmi commented Nov 23, 2022

Questions Answers
Branch? develop
Description? Add theme_dir smarty global var in front contoller
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Related PRs N/A
How to test? You can access any where in the tpl {$urls.theme_dir}
Possible impacts? N/A

@hendaghanmi hendaghanmi requested a review from a team as a code owner November 23, 2022 10:47
@prestonBot
Copy link
Collaborator

Hello @hendaghanmi!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Nov 23, 2022
Copy link
Member

@PululuK PululuK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hendaghanmi

@PululuK PululuK added the Waiting for QA Status: action required, waiting for test feedback label Nov 23, 2022
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hendaghanmi ,

Thank you for your PR, but some checks were not successful!

image

Ping @PrestaShop/prestashop-maintainers could you check it please?

Many thanks !

@MhiriFaten MhiriFaten added Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 24, 2022
@nicosomb
Copy link
Contributor

@MhiriFaten it seems that sanity tests are KO everywhere, see #30387 (same error).

@PululuK
Copy link
Member

PululuK commented Nov 24, 2022

Hi @MhiriFaten @nicosomb
All sanity setups failing, is not related to the PR.

@PululuK PululuK added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for dev Status: action required, waiting for tech feedback labels Nov 24, 2022
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PululuK for your feedback,
But we can not test it until the sanity setups will be repaired.

@MhiriFaten MhiriFaten removed the Waiting for QA Status: action required, waiting for test feedback label Nov 24, 2022
@kpodemski kpodemski added Waiting for QA Status: action required, waiting for test feedback Blocked Status: The issue is blocked by another task labels Nov 24, 2022
@kpodemski
Copy link
Contributor

@MhiriFaten maybe it would be better to keep "Waiting for QA" but with "Blocked" label? otherwise it will be hard to track

@PululuK PululuK closed this Nov 25, 2022
@PululuK PululuK reopened this Nov 25, 2022
@PululuK PululuK removed the Blocked Status: The issue is blocked by another task label Nov 25, 2022
@PululuK
Copy link
Member

PululuK commented Nov 25, 2022

Hi @MhiriFaten it is good now :)

@AureRita AureRita self-assigned this Nov 29, 2022
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hendaghanmi

Thank you for your PR, I tested it and it works, as we can see here :

Untitled_.Nov.29.2022.3_20.PM.webm

Nice first PR !

Thanks !

@AureRita AureRita removed the Waiting for QA Status: action required, waiting for test feedback label Nov 29, 2022
@AureRita AureRita added the QA ✔️ Status: check done, code approved label Nov 29, 2022
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@AureRita AureRita removed their assignment Nov 29, 2022
@PululuK PululuK merged commit 61e6b8f into PrestaShop:develop Nov 29, 2022
@PululuK
Copy link
Member

PululuK commented Nov 29, 2022

Thanks @hendaghanmi @AureRita

@PululuK PululuK added this to the 8.1.0 milestone Nov 29, 2022
@hendaghanmi
Copy link
Contributor Author

Thanks @PululuK

@kpodemski kpodemski added the Needs documentation Needs an update of the developer documentation label Jan 23, 2023
@kpodemski kpodemski added Documentation ✔️ Developer documentation is up-to-date and removed Needs documentation Needs an update of the developer documentation labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Documentation ✔️ Developer documentation is up-to-date Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants