New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme_dir
smarty global var in front contoller
#30383
Conversation
Hello @hendaghanmi! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hendaghanmi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hendaghanmi ,
Thank you for your PR, but some checks were not successful!
Ping @PrestaShop/prestashop-maintainers could you check it please?
Many thanks !
@MhiriFaten it seems that sanity tests are KO everywhere, see #30387 (same error). |
Hi @MhiriFaten @nicosomb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @PululuK for your feedback,
But we can not test it until the sanity setups will be repaired.
@MhiriFaten maybe it would be better to keep "Waiting for QA" but with "Blocked" label? otherwise it will be hard to track |
Hi @MhiriFaten it is good now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hendaghanmi
Thank you for your PR, I tested it and it works, as we can see here :
Untitled_.Nov.29.2022.3_20.PM.webm
Nice first PR !
Thanks !
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
Thanks @hendaghanmi @AureRita |
Thanks @PululuK |
theme_dir
smarty global var in front contoller{$urls.theme_dir}