Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override.css to be used in the new back office theme #30665

Merged
merged 1 commit into from Jan 17, 2023

Conversation

jeckyl
Copy link
Contributor

@jeckyl jeckyl commented Dec 24, 2022

With this solution, it will be possible to customize any backoffice theme by simply adding these customization CSS elements in a file named overrides.css as it is possible to customize a PrestaShop store with the custom.css file

Questions Answers
Branch? develop
Description? Allow on PrestaShop 1.7 and 8 to customize any backoffice theme.
Type? improvement
Category? BO
BC breaks? no
Fixed ticket? Fixes #30664.

With this solution, it will be possible to customize any backoffice theme by simply adding these customization CSS elements in a file named overrides.css as it is possible to customize a PrestaShop store with the custom.css file
@jeckyl jeckyl requested a review from a team as a code owner December 24, 2022 10:35
@prestonBot prestonBot added the Improvement Type: Improvement label Dec 24, 2022
@kpodemski
Copy link
Contributor

Hi @jeckyl

Why not use actionAdminControllerSetMedia and add styles through the module? Don't you think it'd be easier to maintain?

@FabienPapet
Copy link
Member

I don't have any idea about how useful this can be. Just a warning about if this get merged, it won't be available into 1.7 nor 8.0 as we don't add new features on released versions

@PrestaEdit
Copy link
Contributor

Actually, the change is more: allow this overrides.css file to be used even with the new-theme.

@FabienPapet FabienPapet added the Waiting for author Status: action required, waiting for author feedback label Jan 8, 2023
@kpodemski kpodemski changed the title Customize the design of the backoffice theme Allow override.css to be used in the new back office theme Jan 12, 2023
@prestonBot prestonBot added the develop Branch label Jan 12, 2023
@kpodemski kpodemski removed the Waiting for author Status: action required, waiting for author feedback label Jan 12, 2023
@kpodemski kpodemski added Waiting for QA Status: action required, waiting for test feedback Waiting for dev Status: action required, waiting for tech feedback labels Jan 16, 2023
@zuk3975 zuk3975 self-assigned this Jan 17, 2023
@zuk3975
Copy link
Contributor

zuk3975 commented Jan 17, 2023

Tested it, overriding works 👍

  1. created file /themes/new-theme/css/overrides.css
  2. added a test change "body { background-color: black } (see screenshot 1)
  3. Without PR I don't see any changes (see screenshot 2) ❌
  4. With PR I see the overriden css changes as expected (see screenshot 3) ✅

screenshots:
1.Screenshot 2023-01-17 at 15 41 25
2.Screenshot 2023-01-17 at 15 40 44
3.Screenshot 2023-01-17 at 15 41 05

@zuk3975 zuk3975 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback Waiting for dev Status: action required, waiting for tech feedback labels Jan 17, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@zuk3975 zuk3975 added this to the 8.1.0 milestone Jan 17, 2023
@kpodemski kpodemski merged commit f981691 into PrestaShop:develop Jan 17, 2023
@kpodemski
Copy link
Contributor

Thank you @jeckyl 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep a solution to customize the backoffice CSS
6 participants