Revert "Removed deprecated methods & properties in Product class" #31154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
Feb 1, 2023
•
jolelievre
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | This reverts #28548 The PR was merged a bit too quick, a lot of things need to be cleaned along with those fields And we need to investigate why the CI let this pass without problems |
| Type? | bug fix |
| Category? | CO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | ~ |
| How to test? | CI green |
kpodemski
approved these changes
Feb 1, 2023
|
@jolelievre Where do you detect the error ? |
zuk3975
approved these changes
Feb 2, 2023
|
@Progi1984 manual check, CI didn't catch it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.