Fix body classes for manufacturer and supplier listings #31319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PululuK
previously requested changes
Feb 12, 2023
0x346e3730
previously approved these changes
Feb 13, 2023
kpodemski
reviewed
Feb 14, 2023
kpodemski
reviewed
Feb 14, 2023
Hlavtox
force-pushed
the
fix-body-classes
branch
from
5803a3a
to
9f01bb2
Compare
kpodemski
previously approved these changes
Feb 14, 2023
Hlavtox
force-pushed
the
fix-body-classes
branch
from
9f01bb2
to
43ba760
Compare
kpodemski
approved these changes
Feb 14, 2023
SharakPL
approved these changes
Feb 14, 2023
kpodemski
added
the
Waiting for QA
florine2623
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Hello @Hlavtox ,
Automated tests : https://github.com/florine2623/testing_pr/actions/runs/4202318255
LGTM ! It is QA ✅
Thanks!
florine2623
added
QA ✔️
|
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: Attempt to read property "id" on null in controllers\front\listing\ManufacturerController.php on line 242andWarning: Attempt to read property "name" on null in controllers\front\listing\ManufacturerController.php on line 243./brandsand see that the warnings are gone. Visit/brand/2-graphic-cornerand see that body classes are still there.