New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] FO : Invalid combination price in case of ecotax #3471

Merged
merged 2 commits into from Jul 27, 2015

Conversation

Projects
None yet
2 participants
@erouvier29
Contributor

erouvier29 commented Jul 20, 2015

No description provided.

@jnadaud

This comment has been minimized.

Show comment
Hide comment
@jnadaud

jnadaud Jul 27, 2015

Contributor

Hi, thank you for your contribution, can you please add some steps in a comment in order to reproduce this issue ?

Best regards.

Contributor

jnadaud commented Jul 27, 2015

Hi, thank you for your contribution, can you please add some steps in a comment in order to reproduce this issue ?

Best regards.

@erouvier29

This comment has been minimized.

Show comment
Hide comment
@erouvier29

erouvier29 Jul 27, 2015

Contributor
  1. Create a simple product, e.g. retail price with tax: 120€, tax rule: 20%, ecotax (tax incl.): 10€
  2. Open FO product detail -> price = 120€ tax incl., including 10€ for ecotax: OK
  3. Create combinations for above product without any price impact
  4. Re-open FO product detail -> price = 121.67€ tax incl., including 10€ for ecotax: KO
Contributor

erouvier29 commented Jul 27, 2015

  1. Create a simple product, e.g. retail price with tax: 120€, tax rule: 20%, ecotax (tax incl.): 10€
  2. Open FO product detail -> price = 120€ tax incl., including 10€ for ecotax: OK
  3. Create combinations for above product without any price impact
  4. Re-open FO product detail -> price = 121.67€ tax incl., including 10€ for ecotax: KO
@jnadaud

This comment has been minimized.

Show comment
Hide comment
@jnadaud

jnadaud Jul 27, 2015

Contributor

Hi, I can't reproduce please see attached images:

screenshot 2015-07-27 12 06 28
screenshot 2015-07-27 12 06 50
screenshot 2015-07-27 12 07 08
screenshot 2015-07-27 12 07 19

Contributor

jnadaud commented Jul 27, 2015

Hi, I can't reproduce please see attached images:

screenshot 2015-07-27 12 06 28
screenshot 2015-07-27 12 06 50
screenshot 2015-07-27 12 07 08
screenshot 2015-07-27 12 07 19

@erouvier29

This comment has been minimized.

Show comment
Hide comment
@erouvier29

erouvier29 Jul 27, 2015

Contributor

Sorry, I forgot to specify that the issue occurs when there is a tax on ecotax (it is the case in France).
I guess you didn't set it...

Contributor

erouvier29 commented Jul 27, 2015

Sorry, I forgot to specify that the issue occurs when there is a tax on ecotax (it is the case in France).
I guess you didn't set it...

jnadaud pushed a commit that referenced this pull request Jul 27, 2015

Jérôme Nadaud
Merge pull request #3471 from eric-rouvier/patch-11
[-] FO : Invalid combination price in case of ecotax

@jnadaud jnadaud merged commit 79370fe into PrestaShop:1.6.1.x Jul 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jnadaud

This comment has been minimized.

Show comment
Hide comment
@jnadaud

jnadaud Jul 27, 2015

Contributor

Yes, you are right, thank you for you contribution.

Best regards.

Contributor

jnadaud commented Jul 27, 2015

Yes, you are right, thank you for you contribution.

Best regards.

@erouvier29 erouvier29 deleted the erouvier29:patch-11 branch Jul 27, 2015

@jnadaud jnadaud added the Bug label Aug 4, 2015

jnadaud added a commit that referenced this pull request Aug 20, 2015

Merge pull request #3471 from eric-rouvier/patch-11
[-] FO : Invalid combination price in case of ecotax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment