Add cart rule module validation

[Hlavtox]

Questions	Answers
Branch?	develop
Description?	Adds a hook to create endless possibilities of cart rules.
Type?	bug fix
Category?	CO
BC breaks?	no
Deprecations?	no
How to test?	Indicate how to verify that this change works as expected.
UI Tests	https://github.com/florine2623/testing_pr/actions/runs/8340742024 ✅
Fixed issue or discussion?
Related PRs	PrestaShop/autoupgrade#672
Sponsor company	TRENDO s.r.o.

New hook

• I added a new hook called actionValidateCartRule which allows you to create absolutely endless possibilities of rules, when the cart rule should be valid. Also, you can use this to speed up prestashop in specific cases by skipping some of the validations. All of those "Buy X and X to get X", "Buy 2x this and get discount" - whatever, easily.
  • If null is provided, nothing happens and built-in validation is ran. Useful if you want your own conditions, but also want to retain functionality of the core.
  • If true is provided, the validation ends here and the rule is VALID, ignoring the rest of core validation.
  • If false is provided, the validation ends here and the rule is not VALID, ignoring the rest of core validation. In this case, it's recommended to properly alter the isValidatedByModulesError error message so the user knows why.
• You can test it with following module - tox_cartrulevalidation.zip, it will validate a cart rule only if there is a product with "umming" in it's name in the cart.

Known issues NOT RELATED TO THIS PR

• If the cart rule is in the cart and you change validity, active or total quantity, it won't be removed. I tried to fix it but it breaks tests, will be done in another PR, in another day. :-)

[Hlavtox]

Ping @kpodemski, it's ready

[ShaiMagal]

LGTM

[AureRita]

Hi @Hlavtox

Thank you for your PR, I tested it and it doesn't seems to works as expected as you can see :

recording.32.webm

Thank you

[Hlavtox]

@AureRita Please read the PR description, I specially written this to avoid QA reporting this - If the cart rule is in the cart and you change validity, active or total quantity, it won't be removed.

Try to change minimum order value for example. Now the rule will be removed on page reload, before, only if you changed something in cart.

[Hlavtox]

Bump @AureRita

[kpodemski]

ping @AureRita @florine2623 :)

[kpodemski]

I'm blocking this PR.

Unfortunately, we have to fix the most common issues first.

[florine2623]

Hello @Hlavtox ,

I'm not sure I understand well this PR. This is not a bug fix but rather an improvement of an existing feature ?
I don't see a "before and after" as you usually add in the how to test section of a PR x)

The new hook actionValidateCartRule is well available on my shop.

I tested this following part : All of those "Buy X and X to get X", "Buy 2x this and get discount" - whatever, easily.
Works as expected ✅

I tested your module tox_cartrulevalidation.zip and it works as you explained.

Is there something else that should be tested ?

Thanks!

[Hlavtox]

Ping @kpodemski could you QA it maybe?

[paulnoelcholot]

Hello @Hlavtox

Some checks haven’t completed yet

[Hlavtox]

@paulnoelcholot Tests green now

[paulnoelcholot]

Hello @Hlavtox,

I tested your PR and it's GOOD for me! 🎉

Thanks!

[jf-viguier]

love it