Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] FO : fix #PSCSX-5963, link to home can be in https #3597

Merged
merged 1 commit into from Aug 4, 2015

Conversation

@gRoussac
Copy link
Contributor

commented Aug 4, 2015

Report of #3315

jnadaud pushed a commit that referenced this pull request Aug 4, 2015
Jérôme Nadaud
Merge pull request #3597 from gRoussac/PSCSX-5963-2
[-] FO  : fix #PSCSX-5963, link to home can be in https

@jnadaud jnadaud merged commit 191cefe into PrestaShop:1.6.1.x Aug 4, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jnadaud jnadaud added the Bug label Aug 4, 2015

@kpodemski

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2015

isn't better to make $base_dir with https if force_ssl is true?

@gRoussac

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2015

Hi Krystian,

Please see my answer on #3315

Regards

@kpodemski

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2015

Hi @gRoussac

Ok, I see your point.

thanks

jnadaud pushed a commit that referenced this pull request Aug 20, 2015
Jérôme Nadaud Jérôme Nadaud
Merge pull request #3597 from gRoussac/PSCSX-5963-2
[-] FO  : fix #PSCSX-5963, link to home can be in https
jnadaud pushed a commit that referenced this pull request Aug 20, 2015
Jérôme Nadaud Jérôme Nadaud
Merge pull request #3597 from gRoussac/PSCSX-5963-2
[-] FO  : fix #PSCSX-5963, link to home can be in https
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.