Skip to content

Add new hook in object presenter - #37947

Merged
kpodemski merged 2 commits into
PrestaShop:9.0.xfrom
web-cooking-factory:feature/hook-object-presenter
Feb 19, 2025
Merged

Add new hook in object presenter#37947
kpodemski merged 2 commits into
PrestaShop:9.0.xfrom
web-cooking-factory:feature/hook-object-presenter

Conversation

@web-cooking-factory

@web-cooking-factory web-cooking-factory commented Jan 31, 2025 •
edited by paulnoelcholot
Loading

Copy link
Copy Markdown
Contributor
Questions Answers
Branch? 9.0.x
Description? Add new hook in object presenter
Type? new feature
Category? CO
BC breaks? no
Deprecations? no
How to test? N/A
UI Tests https://github.com/paulnoelcholot/testing_pr/actions/runs/13410540848
Fixed issue or discussion? N/A
Related PRs #34781 PrestaShop/autoupgrade#1150
Sponsor company Evolutive

@web-cooking-factory
web-cooking-factory requested a review from a team as a code owner January 31, 2025 08:17
@web-cooking-factory

web-cooking-factory commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

@kpodemski :)

@kpodemski

kpodemski commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

@web-cooking-factory you chose a wrong branch

@web-cooking-factory

web-cooking-factory commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

@kpodemski 9.0.x ?

@web-cooking-factory
web-cooking-factory changed the base branch from develop to 9.0.x January 31, 2025 08:40
@web-cooking-factory
web-cooking-factory requested a review from a team as a code owner January 31, 2025 08:40
@web-cooking-factory
web-cooking-factory force-pushed the feature/hook-object-presenter branch from 8565c87 to 848f07f Compare January 31, 2025 08:41
@ps-jarvis ps-jarvis added the Waiting for wording Status: action required, waiting for wording label Jan 31, 2025
@kpodemski

kpodemski commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

@web-cooking-factory yes, that was also what Pululu was asked about, to rebase the PR onto 9.0.x

@web-cooking-factory
web-cooking-factory force-pushed the feature/hook-object-presenter branch from 848f07f to 391e105 Compare January 31, 2025 08:44
@web-cooking-factory

web-cooking-factory commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

@kpodemski ok, done, sorry for that

@kpodemski kpodemski removed the Waiting for wording Status: action required, waiting for wording label Jan 31, 2025
@PrestaShop PrestaShop deleted a comment from ps-jarvis Jan 31, 2025
@kpodemski

kpodemski commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

thank you @web-cooking-factory

the last step is to create a PR for the autoupgrade module:
https://devdocs.prestashop-project.org/8/development/components/hook/register-new-hook/#3-prepare-database-update-for-shop-upgrades

against the dev branch

@web-cooking-factory web-cooking-factory mentioned this pull request Jan 31, 2025
Merged
@web-cooking-factory

web-cooking-factory commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

@kpodemski Ok, done (thanks for the help) : PrestaShop/autoupgrade#1150

boherm
boherm approved these changes Jan 31, 2025
View reviewed changes

@boherm boherm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @web-cooking-factory!

@boherm boherm added this to the 9.0.0 milestone Jan 31, 2025
@web-cooking-factory

web-cooking-factory commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

Hi @gericfo, the autoupgrade PR is here : PrestaShop/autoupgrade#1150

@gericfo

gericfo commented Jan 31, 2025

Copy link
Copy Markdown

Thanks @web-cooking-factory!

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jan 31, 2025
@kpodemski kpodemski closed this Feb 3, 2025
@kpodemski kpodemski reopened this Feb 3, 2025
@jolelievre

jolelievre commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Thanks for the autoupgrade PR @web-cooking-factory

Just FYI this step should not be required to be done manually anymore, we now have a CLI command that generates the upgrade script, as long as the new hook is correctly added in the hokk.xml fixture file. A step will be added in our release process to run this command for each release, so don't bother next time 😉

@paulnoelcholot paulnoelcholot self-assigned this Feb 19, 2025
@paulnoelcholot

paulnoelcholot commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Hello @web-cooking-factory,

It's OK for me! 🎉
Thanks!

Automated test : https://github.com/paulnoelcholot/testing_pr/actions/runs/13410540848

@paulnoelcholot paulnoelcholot added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 19, 2025
@kpodemski
kpodemski merged commit 389707e into PrestaShop:9.0.x Feb 19, 2025
@kpodemski

kpodemski commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

thank you @web-cooking-factory

@kpodemski kpodemski added the Needs documentation Needs an update of the developer documentation label Feb 19, 2025
@PululuK

PululuK commented Feb 19, 2025

Copy link
Copy Markdown
Member

Thanks @web-cooking-factory , very good feature !

@kpodemski we can close the initial PR #34781

@Quetzacoalt91 Quetzacoalt91 added the PR Autoupgrade opened ✔️ The associated PR has been opened in the Autoupgrade module repository. label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpodemski kpodemski kpodemski approved these changes
@jolelievre jolelievre jolelievre approved these changes
@PululuK PululuK PululuK approved these changes
@boherm boherm boherm approved these changes

Assignees

@paulnoelcholot paulnoelcholot

Labels

develop Branch Feature Type: New Feature Hook Contribution Needs autoupgrade PR Needs documentation Needs an update of the developer documentation PR Autoupgrade opened ✔️ The associated PR has been opened in the Autoupgrade module repository. QA ✔️ Status: check done, code approved

Projects

PR Dashboard
Archived in project

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@web-cooking-factory @kpodemski @gericfo @jolelievre @paulnoelcholot @PululuK @boherm @Quetzacoalt91 @ps-jarvis