Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] FO : Fix #PSCSX-5182, for newsletter flag for customer if previously registred as guest #3809

Merged
merged 1 commit into from Sep 18, 2015

Conversation

@gRoussac
Copy link
Contributor

commented Aug 25, 2015

…sly registred as guet

@gRoussac

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2015

⚠️ NEEDS TO BE MERGED AFTER PrestaShop/blocknewsletter#15

@tchauviere

View changes

controllers/front/AuthController.php Outdated
@@ -359,15 +359,22 @@ protected function processSubmitLogin()
*/
protected function processCustomerNewsletter(&$customer)
{
$blocknewsletter = Module::isInstalled('blocknewsletter') && $module_newsletter = Module::getInstanceByName('blocknewsletter');
if ($blocknewsletter && $module_newsletter->active && !Tools::getValue('newsletter')) {
if ($module_newsletter->isNewsletterRegistered2($_POST['email']) == $module_newsletter::GUEST_REGISTERED) {

This comment has been minimized.

Copy link
@tchauviere

tchauviere Sep 18, 2015

Contributor

Tools::getValue() here ? instead of $_POST ?

@gRoussac gRoussac force-pushed the gRoussac:PSCSX-5182-3 branch to c954d3a Sep 18, 2015

@gRoussac

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2015

done 💂

@tchauviere

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2015

👍

tchauviere added a commit that referenced this pull request Sep 18, 2015
Merge pull request #3809 from gRoussac/PSCSX-5182-3
[-] FO : Fix #PSCSX-5182, for newsletter flag for customer if previously registred as guest

@tchauviere tchauviere merged commit beafafa into PrestaShop:1.6.1.x Sep 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gRoussac gRoussac deleted the gRoussac:PSCSX-5182-3 branch Sep 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.