Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] Project: Small fixes for use with PHP7 #4175

Merged
merged 7 commits into from Nov 9, 2015

Conversation

@prestamodule
Copy link
Contributor

commented Oct 5, 2015

No description provided.

@julienbourdeau

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2015

Hi,

Can you detail this line ? (https://github.com/PrestaShop/PrestaShop/pull/4175/files#diff-d373723286a172a4ca3d76c4858f565bR1384)

(PHP_MAJOR_VERSION < 7 && !Validate::$values['validation'](Tools::getValue($field))) || !Validate::{$values['validation']}(Tools::getValue($field))

What problem are you trying to solve ?

@PrestaEdit

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2015

Hi @julienbourdeau,

It's a fix that some days ago... Don't remember the way I do for have the error but it was a things like: "Can't access to an undeclared variable". Will try to see to have the error again...

@PrestaEdit

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2015

Hi @julienbourdeau,

This error: "Fatal error: Uncaught Error: Access to undeclared static property: Validate::$values" when you wan't to update an option attach to an AdminController, is this ;-)

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Oct 23, 2015

👍

This closes #4298

@PrestaEdit

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2015

I take your commit, cause it's really easier like this, for handle the _destruct ; to complete this one, :)

@julienbourdeau julienbourdeau added this to the 1.6.1.3 milestone Oct 25, 2015

@therampagerado

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2015

Will support for php7 be added into 1.6.1.2? Currently I have white screen when switching to 7

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Oct 26, 2015

Hi @therampagerado,

Before asking for support, you always have to enable the Dev mode in order to have more details on the issue. 😉

@jnadaud jnadaud added the Code ✔️ label Nov 4, 2015

jnadaud pushed a commit that referenced this pull request Nov 9, 2015
Jérôme Nadaud
Merge pull request #4175 from prestamodule/PHP7_#1
[*] Project: Small fixes for use with PHP7

@jnadaud jnadaud merged commit 9eb5673 into PrestaShop:develop Nov 9, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@Quetzacoalt91 Quetzacoalt91 added the PHP7 label Dec 3, 2015

@ram-you

This comment has been minimized.

Copy link

commented Dec 9, 2015

Webservice is not 100% compatible with php7.
"SITENAME/api/products/?ws_key=xxxxxxxxxxxxxxxxxxxxxxx&output_format=xml" works.
"SITENAME/api/products/?ws_key=xxxxxxxxxxxxxxxxxxxxxxx&output_format=JSON" doesn't work.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.