Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//Manufacturers and suppliers display #4235

Conversation

@maximebiloe
Copy link
Contributor

commented Oct 8, 2015

This is a POC to manage Suppliers and Manufacturers display.
Do you have any suggestions about structure and/or HTML markup ?

Here is the structure suggested for :

  • List of products
    capture d ecran 2015-10-08 a 18 43 04
  • Manufacturers and Suppliers aka Brands
    capture d ecran 2015-10-08 a 18 43 10

Do not hesitate to comment.

@@ -0,0 +1,17 @@
{if $products|count}
<section id="products">
<h1>{l s='Products'}</h1>

This comment has been minimized.

Copy link
@gskema

gskema Oct 9, 2015

Contributor

This should probably be h2 or lower

This comment has been minimized.

Copy link
@djfm

djfm Oct 18, 2015

Contributor

I think the h1 is correct, because it is inside a section.

This comment has been minimized.

Copy link
@gskema

gskema Oct 18, 2015

Contributor

There must be only one h1 in a document, having more than one is a SEO mistake. Sections must have a heading element, but it doesn't have to be h1 (can be h2, h3, etc.)

@gskema

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2015

I agree on the structure {some_page_with_products}.tpl > products.tpl > product-miniature.tpl.
As for the product list I believe this naming would make more sense:

product-list.tpl
product-list-item.tpl

But then I thought about sliders, where *-miniature.tpl makes sense and *-list-item - not so much.
Regardless I'd probably stick with *-list.tpl and *-list-item.tpl.
If the slides differ much from list item, you can always make a new template/extend.

What do others think?

@maximebiloe

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2015

Hi @gskema,

Thanks for your remarks.

About the h1 tag in the <section id="products">, we have a Trello card about it (https://trello.com/c/WNUilMDk/151-ensure-all-section-s-have-a-h1), it's still in thinking. So, we take all remarks in consideration.

About the structure, we wanted to be consistent regarding what has been already done about categories but we still listen to others opinions.

@inetbiz

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2015

I have a PR already on structure. Products in a category listing is an itemlist. #4232 @maximebiloe could you examine, please?

@maximebiloe maximebiloe force-pushed the maximebiloe:starter-theme/feat/manufacturers branch to 3faae04 Oct 19, 2015

@djfm

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2015

@inetbiz thanks, I'll get to yours right after this one!

djfm added a commit that referenced this pull request Oct 19, 2015
Merge pull request #4235 from maximebiloe/starter-theme/feat/manufact…
…urers

//Manufacturers and suppliers display

@djfm djfm merged commit 487c64e into PrestaShop:feat/starter-theme Oct 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maximebiloe maximebiloe deleted the maximebiloe:starter-theme/feat/manufacturers branch Feb 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.