Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

// IN: Remove mail_identifiers email template and code #4309

Merged

Conversation

@julienbourdeau
Copy link
Contributor

commented Oct 19, 2015

This email haven't been sent in years. We don't ask for smtp config during the install process so there is no way it works.
It's not a good practice to send the admin password by email anyway.

@maximebiloe

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2015

👍

// IN: Remove mail_identifiers email template and code
This email haven't been sent in years. We don't ask for smtp config during the install process so there is no way it works.
It's not a good practice to send the admin password by email anyway.

@julienbourdeau julienbourdeau force-pushed the julienbourdeau:feat/installer-remove-unused-code branch to 90be9ae Oct 19, 2015

@julienbourdeau

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2015

Also fixes #4237

gaillafr added a commit that referenced this pull request Oct 19, 2015
Merge pull request #4309 from julienbourdeau/feat/installer-remove-un…
…used-code

// IN: Remove mail_identifiers email template and code

@gaillafr gaillafr merged commit 5919de9 into PrestaShop:develop Oct 19, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@julienbourdeau julienbourdeau deleted the julienbourdeau:feat/installer-remove-unused-code branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.