Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] BO CSV: new Export CSV for new Product catalog admin page. #4689

Merged
merged 1 commit into from Jan 13, 2016

Conversation

@xGouley
Copy link
Member

commented Jan 13, 2016

No description provided.

true, null, null, null, $nothing, true, true);
$product['price_final'] = \ToolsCore::displayPrice($product['price_final'], $currency);
(int)\Configuration::get('PS_PRICE_DISPLAY_PRECISION'), null, false, true, 1,
true, null, null, null, $nothing, true, true);

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Jan 13, 2016

Member

$nothing is undefined or global, right ?

This comment has been minimized.

Copy link
@xGouley

xGouley Jan 13, 2016

Author Member

$nothing is undefined. Mandatory due to legacy code that we cannot change for our Adapter needs.

{
// init vars
$productProvider = $this->container->get('prestashop.core.admin.data_provider.product_interface');
/* @var $productProvider ProductInterfaceProvider */

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Jan 13, 2016

Member

Can you reverse the PHPDoc annotation and the variable declaration ?

/* @var $productProvider ProductInterfaceProvider */
$productProvider = $this->container->get('prestashop.core.admin.data_provider.product_interface');

I'm not sure the parsed information is valid this way...

This comment has been minimized.

Copy link
@xGouley

xGouley Jan 13, 2016

Author Member

The annotation works in Eclipse and PHPStorm in this way. If there is documentation on the official syntax, I will follow it.

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Jan 13, 2016

Member

Ok, thanks for information

kelu95 added a commit that referenced this pull request Jan 13, 2016
Merge pull request #4689 from xGouley/csv_export
[+] BO CSV: new Export CSV for new Product catalog admin page.

@kelu95 kelu95 merged commit b53fbd4 into PrestaShop:develop Jan 13, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@xGouley xGouley deleted the xGouley:csv_export branch Jan 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.