[*] StarterTheme: define image type in theme.yml #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,6 +83,19 @@ global_settings: | |||
| - category | |||
| - index | |||
|
|
|||
| image_types: | |||
| # When theme will be enabled, all image types will be removed | |||
| # Template must declare their image type. | |||
There was a problem hiding this comment.
what about multi-store? what if one theme uses some types and other theme different?!
There was a problem hiding this comment.
Like we said on Gitter (I say it here for history, I mean History) this feature isn't multistore yet. We'll add this later. :)
maximebiloe
force-pushed
the
feat/starter-theme
branch
2 times, most recently
from
a1e5319
to
3f50d23
Compare
julienbourdeau
force-pushed
the
starter-theme/feat/image-types
branch
2 times, most recently
from
0ff321d
to
a617952
Compare
maximebiloe
force-pushed
the
feat/starter-theme
branch
from
bc99d5d
to
a70e314
Compare
Image types are defined in theme.yml
julienbourdeau
force-pushed
the
starter-theme/feat/image-types
branch
from
a617952
to
b9dda2b
Compare
julienbourdeau
removed
the
Waiting for rebase
maximebiloe
force-pushed
the
starter-theme/feat/image-types
branch
from
46dfe5d
to
45e2dbc
Compare
maximebiloe
pushed a commit
that referenced
this pull request
Feb 15, 2016
…-types [*] StarterTheme: define image type in theme.yml
mickaelandrieu
pushed a commit
that referenced
this pull request
Mar 14, 2016
…-types [*] StarterTheme: define image type in theme.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.