Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

// wording/translation #4887

Merged
merged 1 commit into from Feb 5, 2016

Conversation

@kelu95
Copy link
Contributor

commented Feb 5, 2016

No description provided.

xGouley added a commit that referenced this pull request Feb 5, 2016

@xGouley xGouley merged commit 4692727 into PrestaShop:develop Feb 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2016

Has @AlexEven had a chance to see all these?
I wonder about

  • "BAN-13" replacing "EAN-13" -- I never heard of BAN-13, what is it?
  • "Cost price" replacing "Pre-tax wholesale price" in ProductCombination.php (Alex is digging into this currently, I think)
  • "Price - Tax excluded" replacing "Pre-tax wholesale price" in ProductPrice.php
  • "Retail price" replacing "Selling price" in Product/form.html.twig
  • Adding ":" (I think we chose to never end labels with ":")

Also, could you give us more details about the whole "placeholder" thing. If that's what I think it is, OH YEAH! :)

@AlexEven

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2016

@xBorderie It comes from the mock-ups, but I'll check the whole thing now that it's live on the software. Thanks for the feedback!

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2016

Let me just say that I'm pretty sure it should still be EAN-13 :)

The numbers encoded in EAN-13 bar codes are product identification numbers, which are also called Japanese Article Numbers (JAN) in Japan.

@ket4z

This comment has been minimized.

Copy link

commented Feb 9, 2016

EAN-13 is just one of many barcode formats, incidentally used in Europe, surprise. Together with UPC code they are globally recognized and unique, however to make the platform more universal, the field should be either called "Barcode" OR leave it at EAN and additional "UPC" code should be introduced.

That is if you want to get it right. In any case BAN-13 is BS...

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2016

Yup, thanks @ket4z, that's pretty my thinking too.
My guess is that BAN-13 is just a mistake that came from the mock-ups. I just made PR #4934 to fix it :)
And we already have a "UPC barcode" barcode :)

@Jonadabe

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2016

https://github.com/tecnickcom/tc-lib-barcode

  1. 1D and 2D barcodes: CODE 39, ANSI MH10.8M-1983, USD-3, 3 of 9, CODE 93, USS-93, Standard 2 of 5, Interleaved 2 of 5, CODE 128 A/B/C, 2 and 5 Digits UPC-Based Extension, EAN 8, EAN 13, UPC-A, UPC-E, MSI, POSTNET, PLANET, RMS4CC (Royal Mail 4-state Customer Code), CBC (Customer Bar Code), KIX (Klant index - Customer index), Intelligent Mail Barcode, Onecode, USPS-B-3200, CODABAR, CODE 11, PHARMACODE, PHARMACODE TWO-TRACKS, Datamatrix, QR-Code, PDF417;

;-)

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2016

Oh my ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.