Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*]BO: Webpack normalization and remove the tests install from the npm install #5027

Merged
merged 7 commits into from Feb 20, 2016

Conversation

@Shudrum
Copy link
Contributor

commented Feb 17, 2016

Now the npm install is optionnal until the need of running the tests.

@Shudrum Shudrum added the WIP label Feb 17, 2016

@kpodemski

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2016

Shudrum added 7 commits Feb 17, 2016
// Material icons integrated to the legacy
(Instead of the temporary Google CDN link)
// Composer install / uninstall action created
With php to avoid bash scripts
// Documentation updated
Due to the simpliest way to install PrestaShop we now have.

@Shudrum Shudrum removed the WIP label Feb 19, 2016

@kpodemski

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2016

@Shudrum ready for tests?

@Shudrum

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2016

@kpodemski ready for merge :)

@kpodemski

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2016

@Shudrum great 👍
cc: @julienbourdeau

@Shudrum

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2016

Ahah, you really want it ^^

So I merge.

Shudrum pushed a commit that referenced this pull request Feb 20, 2016
Julien Martin
Merge pull request #5027 from Shudrum/normalize-npm-webpack
[*]BO: Webpack normalization and remove the tests install from the npm install

@Shudrum Shudrum merged commit 22e426a into PrestaShop:develop Feb 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Shudrum

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2016

Do not hesitate to say if there is still problems.

I cannot test with windows.

@kpodemski

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2016

Hi @Shudrum

It seems that it is working but in back-office I'm still seeing this error:
Uncaught ReferenceError: Globalize is not defined

Newest Opera on Chromium

@Shudrum

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2016

This bug is known, only on the Dashboard, will be fixed soon.

@kpodemski

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2016

Ok, but overall entire installation process went very well, thank you Shudrum :)

Windows users likes it! :D

@Shudrum

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2016

You're welcome!

@Shudrum Shudrum deleted the Shudrum:normalize-npm-webpack branch Feb 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.