Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] CORE : Improve configuration load & get performances #5106

Merged
merged 5 commits into from Apr 14, 2016

Conversation

@jocel1
Copy link
Contributor

commented Mar 1, 2016

No description provided.

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2016

Thank you @jocel1 !
Any idea how we could be test this? :)

@@ -602,6 +602,7 @@ public function executeS($sql, $array = true, $use_cache = true)
}
}

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Mar 17, 2016

Member

can you remove this line please ?

@@ -24,7 +24,7 @@
* International Registered Trademark & Property of PrestaShop SA
*/
namespace PrestaShop\PrestaShop\Tests\Integration\Classes;
namespace PrestaShop\PrestaShop\tests\Integration\classes;

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Mar 17, 2016

Member

nice catch

@jocel1

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2016

@xBorderie : if all the tests passed, it should be ok (it's basically used in every tests :))

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Apr 8, 2016

@xBorderie let's wait for @jocel1, I need to discuss with him some details :)

@Shudrum Shudrum merged commit 1dc726b into PrestaShop:develop Apr 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Shudrum added a commit that referenced this pull request Apr 14, 2016
Merge pull request #5106 from jocel1/hotfix-configurationcore-get
[*] CORE : Improve configuration load & get performances

@jocel1 jocel1 deleted the jocel1:hotfix-configurationcore-get branch Apr 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.