New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] BO : product description can be saved when empty #5197

Merged
merged 1 commit into from Mar 17, 2016

Conversation

Projects
None yet
5 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Mar 16, 2016

Description

At this moment, we cant empty short description in Product form edition: if a value already have been provided, the Form handler from Symfony was unable to manage empty values.

More information here symfony/symfony#5906, this is a workaround as this bug wont probably be fixed in Symfony 2 and is not fixed yet in Symfony 3.

Steps to Test this Fix

  1. Step 1.
    Edit a product that already have a short description, and empty the textarea field.
  2. Step 2.
    Save
  3. Step 3.
    Enjoy the empty field.

Forge Ticket (optional)

Fixes ticket http://forge.prestashop.com/browse/BOOM-372

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Mar 17, 2016

Contributor

Tests didn't trigger. Could you push a dummy commit to trigger them? Thanks!

Contributor

xBorderie commented Mar 17, 2016

Tests didn't trigger. Could you push a dummy commit to trigger them? Thanks!

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Mar 17, 2016

Contributor

Tests OK, I remove empty commit.

Contributor

mickaelandrieu commented Mar 17, 2016

Tests OK, I remove empty commit.

Shudrum pushed a commit that referenced this pull request Mar 17, 2016

Julien Martin
Merge pull request #5197 from mickaelandrieu/boom-372-product-descrip…
…tion-deletion

[-] BO : product description can be saved when empty

@Shudrum Shudrum merged commit 265d6de into PrestaShop:develop Mar 17, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:boom-372-product-description-deletion branch Mar 17, 2016

Shudrum added a commit that referenced this pull request Mar 17, 2016

Merge pull request #5197 from mickaelandrieu/boom-372-product-descrip…
…tion-deletion

[-] BO : product description can be saved when empty

@mickaelandrieu mickaelandrieu restored the mickaelandrieu:boom-372-product-description-deletion branch Apr 15, 2016

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:boom-372-product-description-deletion branch Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment