Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] CORE : Update SwiftMailer #5233

Merged
merged 1 commit into from Apr 13, 2016

Conversation

@firstred
Copy link
Contributor

commented Mar 22, 2016

Description

Same as #5214, but for PrestaShop 1.7

What has changed?

  • Update SwiftMailerBundle to 2.3.11
  • Add swiftmailer/swiftmailer to composer.json, version is 5.4.1
  • Removed swift folder from /tools
  • Update Mail.php to work with the newer SwiftMailer

I haven't found an isolated mailer for the installer, like 1.6 has. Has that been removed with 1.7?

Steps to Test this Fix

  • Send test emails
  • Order something in the store.
  • Try with sendmail and with a direct SMTP connection.
  • Gmail, Outlook, etc. (STARTTLS) are supported with this update. It should be possible to relay emails to these email providers.
@tchauviere

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2016

Hi again @firstred !

Thanks for this PR ! I will review it ASAP.

To answer your question, yes, isolated mailer for installer has been removed in the 1.7. So don't worry about it.

Best regards,

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2016

giphy

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Mar 22, 2016

👍 sounds good to me, time to QA 🐱

@tchauviere tchauviere self-assigned this Apr 13, 2016

@vincentbz vincentbz added QA ✔️ and removed waiting for QA labels Apr 13, 2016

@vincentbz

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2016

Tested and OK, thanks !

@tchauviere tchauviere added this to the 1.7.0.0 milestone Apr 13, 2016

@tchauviere tchauviere removed the Estimate: L label Apr 13, 2016

@tchauviere tchauviere merged commit 06c2a6c into PrestaShop:develop Apr 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tchauviere

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2016

Hi @firstred,

Again, thanks a lot for this huge contribution. Your PR is now merged and we are up to date with SwiftMailer thanks to you !

So Much Win

@firstred

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2016

Nice! We've finally addressed a rather big issue, haven't we? :)

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2016

I'd say! Cup of tea, everyone!

giphy

@vincentbz

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2016

gif minions

Shudrum added a commit that referenced this pull request Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.