Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

// CORE : Remove unused partner request on module page #5279

Merged
merged 1 commit into from Mar 31, 2016

Conversation

@Quetzacoalt91
Copy link
Member

commented Mar 30, 2016

Description

This pull-request removes one request made to the marketplace API. The loading time will be shorter.

Steps to Test this Fix

Nothing should change for the merchant, because the request only contains duplicate modules which are manually removed by the AdminModuleDataProvider.
Anyway, to make sure the pull-request works:

  1. Checkout this PR
  2. In the folder cache/, remove the files:
    • catalog_modules.json
    • _catalog_modules.json
  3. Check the modules list are still loaded (and slightly faster ! wow)

Forge Ticket (optional)

No ticket !

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:remove-partner-api branch to ff51304 Mar 31, 2016

@tchauviere tchauviere merged commit d3b9866 into PrestaShop:develop Mar 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Shudrum added a commit that referenced this pull request Apr 14, 2016
Merge pull request #5279 from Quetzacoalt91/remove-partner-api
// CORE : Remove unused partner request on module page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.