New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fallback to curl when file_get_content() return an empty response #5378

Merged
merged 2 commits into from Sep 27, 2018

Conversation

Projects
None yet
7 participants
@rGaillard
Member

rGaillard commented Apr 13, 2016

Questions Answers
Branch? 1.6.1.x
Description? Follow-up #5014 (hide as before the file_get_contents errors)
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no

This change is Reviewable

@eternoendless eternoendless changed the title from [*] CORE: Add a fallback to curl when file_get_content() return an em… to Add a fallback to curl when file_get_content() return an em… Sep 14, 2018

@eternoendless eternoendless changed the title from Add a fallback to curl when file_get_content() return an em… to Add a fallback to curl when file_get_content() return an empty response Sep 14, 2018

@prestonBot prestonBot added the Bug label Sep 14, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 14, 2018

Member

Note: This bug is already fixed in 1.7

Member

eternoendless commented Sep 14, 2018

Note: This bug is already fixed in 1.7

@eternoendless eternoendless modified the milestones: 1.6.1.21, 1.6.1.22 Sep 24, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 27, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.22, 1.6.1.21 Sep 27, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 27, 2018

Thank you @rGaillard

@eternoendless eternoendless merged commit 3d8da12 into PrestaShop:1.6.1.x Sep 27, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Oct 10, 2018

Member

This PR was found to be incomplete, see #10921

Member

eternoendless commented Oct 10, 2018

This PR was found to be incomplete, see #10921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment