Fix warning when duplicating products #5412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloning a product and image watermarking is on, but the product being copied didn't have its images already watermarked (maybe it wasn't run retroactively) there would be a warning for trying to copy the watermark images that aren't there.
xBorderie
added
Bug
|
Hi, This PR fixes the warning indeed. |
julienbourdeau
added
Code reviewed
and removed
waiting for code review
Waiting for QA
|
Thank you! |
Shudrum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Create a product and add an image
- turn on watermarking (without regenerating images)
- clone the product.
You'll see some warnings being logged.