Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

// CORE : ModuleRepository must keep in cache a broken module too #5413

Conversation

@Quetzacoalt91
Copy link
Member

commented Apr 18, 2016

Questions Answers
Branch? develop
Description? When a module main class is invalid, the error is properly blocked by the ModuleRepository. However, if the test is made a second time on the SAME module, the require_once is not executed and PHP returns directly true.
Type? bug fix
Category? CORE
BC breaks? Nope
Deprecations? Nope
How to test? Use a module which has an non-existing file for require_once and add it to your modules folder/. Then, go to the tab "Notifications" of the module page, and now no error should be displayed.

It's dangerous to go alone ! Take the following module to see the error fixed:
馃搨 test_wrong_require.zip

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

Review OK :)

don't forget to edit the commit name ModuleRepostory => ModuleRepository.

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:fix-module-error-on-multiple-require branch to 2ceaa56 Apr 19, 2016

@Quetzacoalt91 Quetzacoalt91 changed the title // CORE : ModuleRepostory must keep in cache a broken module too // CORE : ModuleRepository must keep in cache a broken module too Apr 19, 2016

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2016

Good catch ! and done !

@tchauviere

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2016

I forced the tests again, waiting for them to pass

@tchauviere tchauviere merged commit 6bdd300 into PrestaShop:develop Apr 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.