Performance opt on scandir() usage #5511
Conversation
- avoid tests inside the loop - avoid to double skip of `index.php`
|
This would probably be also interesting on PS 1.7. What do you think, @jocel1 ? |
| $css_url = str_replace(_PS_ROOT_DIR_, '', $protocol_link.Tools::getMediaServer('').$cache_path.DIRECTORY_SEPARATOR.$file); | ||
| $splitted_css[$css_url] = 'all'; | ||
| } | ||
| foreach (array_diff(scandir($cache_path), array('..', '.')) as $file) { |
There was a problem hiding this comment.
why not computing the array_diff outside of the foreach ?
There was a problem hiding this comment.
Are you sure it would be faster? I can't find any doc about this (not having assigned the array to any variables .. )
There was a problem hiding this comment.
The issue with computing the array_diff within the foreach is that you make the code computing the same value in every loop. By taking the array_diff computation out of the loop and into a variable, you gain some valuable microseconds, I'm sure -- moreover because you computation performs a scandir, which touches upon the filesystem and therefore waaaaaay slower than any regular array creation :)
There was a problem hiding this comment.
My dubt was about to consider or not the (...) part of the loop to be
"inside" it
.. in other words I was not sure that this part of code is evaluated more
than one time ..
I'll do some tests to prove or negate this fact asap
There was a problem hiding this comment.
oups you're right, I mixed up with for / while cases. Seems it's also bad to review code on friday :D
There was a problem hiding this comment.
Always nice to have a reminder, thanks @ZiZuu-store :)
There was a problem hiding this comment.
eheh I'm here for this @xBorderie -_^
|
@xBorderie already made a PR for PS1.7 too ;) #5511 |
|
Ah yes, I see it: #5510. Thanks! |
|
Well, seems good to go. Waiting for a proper review by the dev, then both this PR and #5510 should be in :) |
xBorderie
added
Improvement
maximebiloe
force-pushed
the
1.6.1.x
branch
2 times, most recently
from
f5db7a6
to
c189207
Compare
|
up :) |
|
Since the |
|
Thank you @ZiZuu-store |
maximebiloe
changed the title
ghost
deleted the
/theme/cacheis empty after a clear cache.index.php