Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display attributes list in combinations tab of the product page #5605

Merged

Conversation

@maximebiloe
Copy link
Contributor

commented May 20, 2016

Questions Answers
Branch? develop
Description? Display attributes list in combinations tab of the product page. This allows you to check/uncheck attributes directly from the list to generate your combinations. It's also synchronized with the search input.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-467
How to test? Make a clean install of PrestaShop and go to a product page with combinations. Try to click on attributes, it will add it to the search bar. It will work on the other way too (add an attribute from the search bar and it will check the attribute in the list)

@maximebiloe maximebiloe force-pushed the maximebiloe:dev/feat/product-combinations branch 2 times, most recently May 20, 2016

.js-attribute-checkbox {
display: none;

+.attribute-label {

This comment has been minimized.

Copy link
@Shudrum

Shudrum May 20, 2016

Contributor

+?

This comment has been minimized.

Copy link
@maximebiloe

maximebiloe May 23, 2016

Author Contributor

It's to select the first .attribute-label element right next to .js-attribute-checkbox

@Shudrum

View changes

config/autoload.php Outdated
@@ -30,4 +30,4 @@
require_once(_PS_CLASS_DIR_.'PrestaShopAutoload.php');
spl_autoload_register(array(PrestaShopAutoload::getInstance(), 'load'));

require(_PS_VENDOR_DIR_.'autoload.php');
require(dirname(__FILE__).'/../app/autoload.php');

This comment has been minimized.

Copy link
@Shudrum

Shudrum May 20, 2016

Contributor

As we are on PHP 5.4 now, please use __DIR__ instead of dirname(__FILE__)

@Shudrum

View changes

src/PrestaShopBundle/Resources/views/Admin/Product/Include/form_combinations.html.twig Outdated
<div class="alert alert-info" role="alert">
<i class="material-icons">help</i>
<p class="alert-text">
{{ trans('

This comment has been minimized.

Copy link
@Shudrum

Shudrum May 20, 2016

Contributor

Translations string should be on a single row, no?

@maximebiloe maximebiloe force-pushed the maximebiloe:dev/feat/product-combinations branch to 4bd4061 May 23, 2016

@maximebiloe

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2016

Thanks @Shudrum for the review.
I've made the modifications.

@mickaelandrieu mickaelandrieu merged commit c55654f into PrestaShop:develop May 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented May 23, 2016

Thank you @maximebiloe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.