Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not limit div height for module failure details #5742

Merged
merged 1 commit into from Jun 15, 2016

Conversation

@Quetzacoalt91
Copy link
Member

commented Jun 14, 2016

Questions Answers
Branch? develop
Description? When a module fails and we want to see more details on the failure, we open a div which was limited on its height. This PR removes this limit.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
How to test? Upload a module which fails with a fat error message. The button "Try again" should be properly displayed under the error message, not on it.

Before

capture du 2016-06-14 10-58-36

After

See #5742 (comment)

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:BOOM-735 branch Jun 14, 2016

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Jun 14, 2016

@Quetzacoalt91 can you also make the width "smart enough" ?

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2016

I'll have look and I hope this can be customized with the modal plug-in

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:BOOM-735 branch Jun 14, 2016

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:BOOM-735 branch to b6770f3 Jun 14, 2016

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2016

capture du 2016-06-14 15-48-53

Updated to handle the overflow only with the width.

@maximebiloe maximebiloe merged commit 91bf238 into PrestaShop:develop Jun 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Jun 15, 2016

👍 thank you @Quetzacoalt91

@dSkrbic dSkrbic added the QA ✔️ label Jun 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.