Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design optimizations in cart and checkout #5882

Merged
merged 4 commits into from Jul 22, 2016

Conversation

@paeddl
Copy link
Contributor

commented Jul 20, 2016

Questions Answers
Branch? develop
Description? CSS adaption
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1085

@paeddl paeddl changed the title FO : Bigger unit_price in shopping cart page BOOM-1085 FO : Design optimizations BOOM-1085 BOOM-1098 BOOM-1096 Jul 21, 2016

@@ -2,6 +2,7 @@
<div id="order-items" class="col-md-8">
<h3 class="card-title h3">{l s='Order items' d='Shop.Theme.Checkout'}</h3>
{/block}
<div class="order-confirmation-table">

This comment has been minimized.

Copy link
@maximebiloe

maximebiloe Jul 21, 2016

Contributor

Bad indent. Could you fix it, please?

This comment has been minimized.

Copy link
@paeddl

paeddl Jul 21, 2016

Author Contributor

@maximebiloe maximebiloe changed the title FO : Design optimizations BOOM-1085 BOOM-1098 BOOM-1096 Design optimizations in cart and checkout Jul 22, 2016

@maximebiloe maximebiloe merged commit 67b6d49 into PrestaShop:develop Jul 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2016

Thank you!

@vincentbz

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2016

Hi @paeddl ,

Thanks for that PR. Could you make some small fixes

Align the "per unit" price with the product price, there is a difference there
image

In the BOOM-1096, the borders around shipping method and items are missing
Here is what I have
image

Instead of
image

thanks :)

@paeddl

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2016

Hi @vincentbz
did you recompile the css?

@vincentbz

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2016

hmm no, thanks for the answer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.