Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a specific port in doctrine configuration #5907

Merged

Conversation

@mickaelandrieu
Copy link
Member

commented Jul 25, 2016

Questions Answers
Branch? develop
Description? If a specific port is specified, it should be also added to doctrine configuration.
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1055
How to test? Try an installation with a specific port, the entry database_port in file app/config/parameters.yml should be correctly updated.

More, it fixes the installation in this specific use case :)

Important guidelines

@rGaillard

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

@mickaelandrieu i don't have test, but i think the connection is also not working on sockets.

@rGaillard

View changes

install-dev/models/install.php Outdated
@@ -91,6 +91,12 @@ public function generateSettingsFile(
$secret = Tools::passwdGen(56);
$cookie_key = Tools::passwdGen(8);
$cookie_iv = Tools::passwdGen(56);

if (2 === count(preg_split('#:#', $database_host))) {
$splits = preg_split('#:#', $database_host);

This comment has been minimized.

Copy link
@rGaillard

rGaillard Jul 25, 2016

Contributor

This will not work with an IPv6.

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Jul 25, 2016

Author Member

true, hmmm.. can you confirm PrestaShop is compatible with IPv6 ?

by the way, it's fixed: thanks for report

@mickaelandrieu

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2016

@rGaillard maybe.. wont be part of this ticket but if an issue is spawned of course we will fix it 👍

@mickaelandrieu mickaelandrieu force-pushed the mickaelandrieu:fix-installer-db-with-port branch 3 times, most recently Jul 25, 2016

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Jul 27, 2016

Follow-up: On its side, PrestaShop needs the port inside the host value.

@mickaelandrieu mickaelandrieu force-pushed the mickaelandrieu:fix-installer-db-with-port branch Jul 27, 2016

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Jul 28, 2016

Can you please rebase your PR in order to make the tests pass ?

@mickaelandrieu mickaelandrieu force-pushed the mickaelandrieu:fix-installer-db-with-port branch to 7a8235d Jul 28, 2016

@Quetzacoalt91 Quetzacoalt91 merged commit 9aec7c7 into PrestaShop:develop Jul 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Jul 28, 2016

Thanks dude

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:fix-installer-db-with-port branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.