Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recommended modules popup on old theme #6000

Merged

Conversation

Projects
None yet
3 participants
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Aug 11, 2016

Questions Answers
Branch? develop
Description? The route method for the recommended modules has changed in #5942, which makes the ajax request fail on an HTTP error 405. Unfortunately, this PR does not implement the feature on the new toolbar.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Try to open the recommended modules on an old controller (i.e order).
@@ -24,7 +24,7 @@ admin_module_catalog_refresh:
_legacy_controller: AdminModules

admin_module_catalog_post:
path: /catalog
path: /catalog/recommended

This comment has been minimized.

Copy link
@Quetzacoalt91

Quetzacoalt91 Aug 11, 2016

Author Member

This line remove a duplicate with the module catalog link

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Aug 11, 2016

Contributor

good idea, was my mistake to not update it (I wanted to, and I have forgotten to do it :p)

@Shudrum Shudrum changed the title BO: Fix recommended modules popup on old theme Fix recommended modules popup on old theme Aug 16, 2016

@Shudrum Shudrum merged commit 34a4886 into PrestaShop:develop Aug 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:fix-recommended-modules-popup branch Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.