Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix category thumbnail feature #6046

Merged
merged 2 commits into from Aug 22, 2016

Conversation

@maximebiloe
Copy link
Contributor

commented Aug 19, 2016

Questions Answers
Branch? develop
Description? Fix category thumbnail feature
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1222

@maximebiloe maximebiloe force-pushed the maximebiloe:boom-1222 branch to ec54eb2 Aug 19, 2016

@@ -452,12 +452,12 @@ public function renderForm()
$format = array();
$thumb = $thumb_url = '';
$formated_category= ImageType::getFormattedName('category');

This comment has been minimized.

Copy link
@julienbourdeau

julienbourdeau Aug 19, 2016

Contributor

I think it would be great to rename all formated_xx variables to formatted_xx 🙏

This comment has been minimized.

Copy link
@maximebiloe

maximebiloe Aug 22, 2016

Author Contributor

You're right. Just did it: 03f8f7d

@julienbourdeau julienbourdeau merged commit d91594b into PrestaShop:develop Aug 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@julienbourdeau julienbourdeau deleted the maximebiloe:boom-1222 branch Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.