Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing translations #6121

Merged
merged 1 commit into from Aug 30, 2016

Conversation

@thierrymarianne
Copy link
Contributor

commented Aug 29, 2016

Questions Answers
Branch? develop
Description? Missing translation are now available with keys coming from default catalogue
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1247
How to test? Go to "International" > "Translations" in the back-office and check existence of previously missing domain messages like "AdminNotificationsInfo"

@thierrymarianne thierrymarianne added the WIP label Aug 29, 2016

@thierrymarianne thierrymarianne changed the title Add missing translations Added missing translations Aug 29, 2016

@mickaelandrieu

View changes

src/PrestaShopBundle/Controller/Admin/TranslationsController.php Outdated
* @param $defaultCatalogue
* @return mixed
*/
protected function emptyCatalogueValues($defaultCatalogue)

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Aug 30, 2016

Member

rename defaultCatalogue to catalogue

@mickaelandrieu mickaelandrieu added Code ✔️ and removed WIP labels Aug 30, 2016

@mickaelandrieu mickaelandrieu merged commit 9f0b04f into PrestaShop:develop Aug 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Aug 30, 2016

Thank you @thierrymarianne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.