Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manufacturers and suppliers list to sitemap #6160

Merged
merged 1 commit into from Sep 6, 2016

Conversation

@martinfojtik
Copy link
Contributor

commented Sep 3, 2016

Questions Answers
Branch? develop
Description? Extend sitamap list and fix BOOM-1310
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1310
How to test? Open frontend sitemap

@martinfojtik martinfojtik force-pushed the martinfojtik:patch-22 branch Sep 3, 2016

@martinfojtik martinfojtik force-pushed the martinfojtik:patch-22 branch Sep 5, 2016

@martinfojtik

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2016

yes, i updated the commit name

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

Thank you! Tests are failing for PHP 5.4, any idea why @mickaelandrieu ?

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 6, 2016

No... @martinfojtik you may need to rebase against develop, and pray.

@Shudrum

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

Thank you @martinfojtik! We have an issue about this, so when someone merge this pull request, please close this issue: http://forge.prestashop.com/browse/BOOM-1310

@martinfojtik martinfojtik force-pushed the martinfojtik:patch-22 branch Sep 6, 2016

@martinfojtik martinfojtik force-pushed the martinfojtik:patch-22 branch to 1d5dfc9 Sep 6, 2016

@martinfojtik

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2016

@xBorderie the error in test is somehow related to blocktopmenu

@mickaelandrieu i just rebased it and starting to 🙏

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 6, 2016

@martinfojtik good to me :) Merged!

Thank you!

@mickaelandrieu mickaelandrieu merged commit 56189e0 into PrestaShop:develop Sep 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AlexEven

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2016

Hello hello.
Again, please add the label "Waiting for wording" when new or updated content is introduced.
We no longer use "manufacturer", but "brand" instead.
I'll update the content but please pay attention when you see "manufacturer"!
Thank you!

@martinfojtik martinfojtik deleted the martinfojtik:patch-22 branch Nov 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.