Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credit split pdf generation #6180

Merged
merged 1 commit into from Sep 6, 2016

Conversation

@antoin-m
Copy link
Contributor

commented Sep 6, 2016

Questions Answers
Branch? develop
Description? The credit slip pdf wasn't generated because an undefined instance variable was used
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1322
How to test?
  • FO: Buy a product
  • BO: Return it
  • BO: Add a partial refund for this order
  • FO: Go to your credit slips
  • FO: Open the pdf
  • Shouldn't break
@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 6, 2016

Booh ! tests are broken 💥

Hurra tests are green ! 😃

@vincentbz

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

Tested and ok, thanks !

@prestonBot prestonBot added the QA ✔️ label Sep 6, 2016

@mickaelandrieu mickaelandrieu merged commit 3252c3f into PrestaShop:develop Sep 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 6, 2016

Merged, thanks !

Happy first pull request merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.