Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed product sorting by category #6234

Merged
merged 4 commits into from Sep 12, 2016

Conversation

@thierrymarianne
Copy link
Contributor

commented Sep 8, 2016

Questions Answers
Branch? develop
Description? Sort product by category from the back-office
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1376
How to test? Products in front-office should be sorted accordingly
@mickaelandrieu

View changes

src/PrestaShopBundle/Controller/Admin/ProductController.php Outdated
$productList = array_combine($productIdList, $productPositionList);
$productUpdater->sortProductIdList(
$productList,
['filter_category' => $persistedFilterParams['filter_category']]

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Sep 8, 2016

Member

can you keep the long array() notation please ? sorry :/

This comment has been minimized.

Copy link
@thierrymarianne

thierrymarianne Sep 8, 2016

Author Contributor

sorry, hard to change habits :/

This comment has been minimized.

Copy link
@thierrymarianne

thierrymarianne Sep 8, 2016

Author Contributor

I was influenced by the lines above and below, which I'm going to fix as well :$

@mickaelandrieu

View changes

src/PrestaShopBundle/Controller/Admin/ProductController.php Outdated
$productUpdater->sortProductIdList(
$productList,
['filter_category' => $persistedFilterParams['filter_category']]
);
$this->addFlash('success', $translator->trans('Products successfully sorted.', [], 'Admin.Catalog.Notification'));

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Sep 8, 2016

Member

I know this file have some coding style issue, should we update it now ?

@vincentbz

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2016

Tested and ok, thanks !

@prestonBot prestonBot added the QA ✔️ label Sep 9, 2016

@maximebiloe maximebiloe merged commit 50a7f87 into PrestaShop:develop Sep 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.