Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Parent/Child theme feature #6474

Merged
merged 6 commits into from Sep 26, 2016

Conversation

@julienbourdeau
Copy link
Contributor

commented Sep 26, 2016

Questions Answers
Branch? develop
Description? Here it is! You can create child theme very easily and unleash the power of PrestaShop new themes!
Type? new feature
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Read this doc (to be updated and detailed soon). Create a child theme, only the config/theme.yml is needed and below is the minimal content required
name: childtheme
parent: classic
display_name: Child Theme

assets:
  use_parent_assets: true

@julienbourdeau julienbourdeau force-pushed the julienbourdeau:feat/parent-theme branch Sep 26, 2016

@julienbourdeau julienbourdeau force-pushed the julienbourdeau:feat/parent-theme branch to 735ccfd Sep 26, 2016

@julienbourdeau julienbourdeau merged commit 5357f53 into PrestaShop:develop Sep 26, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@@ -27,6 +27,11 @@
/* Theme URLs */
define('_PS_DEFAULT_THEME_NAME_', 'classic');
define('_PS_THEME_DIR_', _PS_ROOT_DIR_.'/themes/'._THEME_NAME_.'/');
if (_PARENT_THEME_NAME_) {

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Sep 26, 2016

Member

you need to use defined or isset else this will dispatch an error.

@julienbourdeau julienbourdeau deleted the julienbourdeau:feat/parent-theme branch Sep 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.